Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268574: ProblemList tests failing due to UseBiasedLocking going away #4469

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 10, 2021

A trivial fix to ProblemList tests failing due to UseBiasedLocking going away


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268574: ProblemList tests failing due to UseBiasedLocking going away

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4469/head:pull/4469
$ git checkout pull/4469

Update a local copy of the PR:
$ git checkout pull/4469
$ git pull https://git.openjdk.java.net/jdk pull/4469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4469

View PR using the GUI difftool:
$ git pr show -t 4469

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4469.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 10, 2021

/label add hotspot-runtime
/label add serviceability

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Jun 10, 2021
@openjdk openjdk bot added the rfr label Jun 10, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 10, 2021

@plummercj - Thanks for the fast review!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268574: ProblemList tests failing due to UseBiasedLocking going away

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

Going to push as commit 2e900da.

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@dcubed-ojdk Pushed as commit 2e900da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8268574 branch Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
2 participants