Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257038: Remove expired flags in JDK 18 #4470

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 10, 2021

Simple start of release update:

  • remove 4 expired flags
  • move the now obsoleted flags to the obsoleted flag section
  • update the dummy obsoleted flag

None of the expired flags were documented so no updated needed to any docs in that regard.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4470/head:pull/4470
$ git checkout pull/4470

Update a local copy of the PR:
$ git checkout pull/4470
$ git pull https://git.openjdk.java.net/jdk pull/4470/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4470

View PR using the GUI difftool:
$ git pr show -t 4470

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4470.diff

 - remove 4 expired flags
 - move the now obsoleted flags to the obsoleted flag section
 - update the dummy obsoleted flag
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Jun 10, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Jun 11, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257038: Remove expired flags in JDK 18

Reviewed-by: kbarrett, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • df65237: 8267930: Refine code for loading hsdis library
  • 2e900da: 8268574: ProblemList tests failing due to UseBiasedLocking going away

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 11, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

On 11/06/2021 11:32 am, Kim Barrett wrote:

On Thu, 10 Jun 2021 23:15:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

Simple start of release update:
- remove 4 expired flags
- move the now obsoleted flags to the obsoleted flag section
- update the dummy obsoleted flag

None of the expired flags were documented so no updated needed to any docs in that regard.

Thanks,
David

Looks good.

Thanks Kim!

David
-----

2 similar comments
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

On 11/06/2021 11:32 am, Kim Barrett wrote:

On Thu, 10 Jun 2021 23:15:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

Simple start of release update:
- remove 4 expired flags
- move the now obsoleted flags to the obsoleted flag section
- update the dummy obsoleted flag

None of the expired flags were documented so no updated needed to any docs in that regard.

Thanks,
David

Looks good.

Thanks Kim!

David
-----

@mlbridge
Copy link

mlbridge bot commented Jun 11, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

On 11/06/2021 11:32 am, Kim Barrett wrote:

On Thu, 10 Jun 2021 23:15:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

Simple start of release update:
- remove 4 expired flags
- move the now obsoleted flags to the obsoleted flag section
- update the dummy obsoleted flag

None of the expired flags were documented so no updated needed to any docs in that regard.

Thanks,
David

Looks good.

Thanks Kim!

David
-----

Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good.

@dholmes-ora
Copy link
Member Author

dholmes-ora commented Jun 11, 2021

Thanks Calvin!

@dholmes-ora
Copy link
Member Author

dholmes-ora commented Jun 13, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2021

Going to push as commit 1ba4e0c.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 90c1034: 8268644: ProblemList serviceability/sa/ClhsdbJstackXcompStress.java in -Xcomp mode
  • 5cee23a: 8265518: C1: Intrinsic support for Preconditions.checkIndex
  • a466b49: 8267634: Update --release 17 symbol information for JDK 17 build 26
  • 49112fa: 8265909: build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home
  • 94d0b0f: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • df65237: 8267930: Refine code for loading hsdis library
  • 2e900da: 8268574: ProblemList tests failing due to UseBiasedLocking going away

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 13, 2021
@openjdk
Copy link

openjdk bot commented Jun 13, 2021

@dholmes-ora Pushed as commit 1ba4e0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8257038 branch Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants