Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268556: Use bitmap for storing regions that failed evacuation #4471

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 11, 2021

Hi all,

can I have reviews for this follow-up cleanup of the earlier JDK-8267073? It introduced a byte-map for storing information about regions that have already been experienced an evacuation failure.

During review the improvement to use a bitmap instead came up - uses less space and there are existing setters/getters that can be used.

Testing: tier1-4


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268556: Use bitmap for storing regions that failed evacuation

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4471/head:pull/4471
$ git checkout pull/4471

Update a local copy of the PR:
$ git checkout pull/4471
$ git pull https://git.openjdk.java.net/jdk pull/4471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4471

View PR using the GUI difftool:
$ git pr show -t 4471

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4471.diff

@tschatzl tschatzl marked this pull request as ready for review Jun 11, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 11, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 11, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268556: Use bitmap for storing regions that failed evacuation

Reviewed-by: kbarrett, iwalulya, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

  • 2d088fa: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • e844610: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • 3637e50: Merge
  • 9f7851b: 8260194: Update the documentation for -Xcheck:jni
  • ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
  • f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
  • 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
  • 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
  • 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
  • 38dbe05: 8268901: JDK-8268768 missed removing two files
  • ... and 60 more: https://git.openjdk.java.net/jdk/compare/94d0b0f9810bd1a8da06ec267a1c7589d6cb756b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 11, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jun 17, 2021

Thanks @kimbarrett @kstefanj @walulyai for you reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

Going to push as commit f2afe0a.
Since your change was applied there have been 70 commits pushed to the master branch:

  • 2d088fa: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • e844610: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • 3637e50: Merge
  • 9f7851b: 8260194: Update the documentation for -Xcheck:jni
  • ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
  • f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
  • 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
  • 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
  • 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
  • 38dbe05: 8268901: JDK-8268768 missed removing two files
  • ... and 60 more: https://git.openjdk.java.net/jdk/compare/94d0b0f9810bd1a8da06ec267a1c7589d6cb756b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@tschatzl Pushed as commit f2afe0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8268556-use-bitmap-for-evacuation-failed-regions branch Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
4 participants