Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows #448

Closed

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Sep 30, 2020

The new lib-test/jdk/test/lib/hexdump/ASN1FormatterTest should be put on the problem list until the problem with newline counting on Windows is fixed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/448/head:pull/448
$ git checkout pull/448

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2020

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2020
@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 30, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2020

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
  • 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
  • 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
  • ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2020
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Sep 30, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2020
@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@RogerRiggs Since your change was applied there have been 4 commits pushed to the master branch:

  • 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
  • 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
  • 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
  • ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti

Your commit was automatically rebased without conflicts.

Pushed as commit 05a764f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8253883-pl-ans1formatter branch October 1, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants