8268873: Unnecessary Vector usage in java.base #4482

turbanoff · 2021-06-14T11:34:50Z

Usage of thread-safe collection Vector is unnecessary. It's recommended to use ArrayList if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized.
I checked only places where Vector was used as local variable.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8268873: Unnecessary Vector usage in java.base

Reviewers

Sean Mullan (@seanjmullan - Reviewer)
@stsypanov (no known github.com user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4482/head:pull/4482
$ git checkout pull/4482

Update a local copy of the PR:
$ git checkout pull/4482
$ git pull https://git.openjdk.java.net/jdk pull/4482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4482

View PR using the GUI difftool:
$ git pr show -t 4482

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4482.diff

bridgekeeper · 2021-06-14T11:35:01Z

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-06-14T11:37:09Z

@turbanoff The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

AlanBateman · 2021-06-14T13:55:54Z

/label add security

openjdk · 2021-06-14T13:56:33Z

@AlanBateman
The security label was successfully added.

mbien · 2021-06-15T16:05:06Z

src/java.base/share/classes/sun/security/pkcs/PKCS7.java

            SignerInfo[] result = new SignerInfo[intResult.size()];
-            intResult.copyInto(result);
-            return result;
+            return intResult.toArray(result);


could be simplified to
return intResult.toArray(new SignerInfo[0]);
which would eliminate array zeroing as bonus as I have learned from your other PR ;)

I considered this, when I was preparing the patch. But decided to reduce scope of changes.

stsypanov · 2021-06-16T08:44:36Z

I've filed https://bugs.openjdk.java.net/browse/JDK-8268873 for this, just put /issue 8268873 as a comment for this ticket to bind it to the issue

src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java

turbanoff · 2021-06-16T09:17:18Z

/issue 8268873

openjdk · 2021-06-16T09:17:53Z

@turbanoff The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

mlbridge · 2021-06-16T09:22:46Z

Webrevs

00: Full (1168936e)

seanjmullan

The change to PKCS7::verify(byte[]) looks fine.

openjdk · 2021-06-18T18:29:56Z

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268873: Unnecessary Vector usage in java.base

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

e515873: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java
51d9159: 8236212: CompiledMethodLoad and CompiledMethodUnload events can be posted in START phase
280f2d5: 8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection
f375916: 8269186: [REDO] Remove CodeCache::mark_for_evol_deoptimization() method
7621fa3: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
f3ba269: 8256306: ObjectMonitor::_contentions field should not be 'jint'
52d5d1b: 8269188: [BACKOUT] Remove CodeCache::mark_for_evol_deoptimization() method
f2e690e: 8268720: Unspecified checks on NameAndType constants should not be performed
2c29d79: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
6237630: 8269120: Build failure with GCC 6.3.0 after JDK-8017163
... and 144 more: https://git.openjdk.java.net/jdk/compare/5cee23a9ed0b7fe2657be7492d9c1f78fcd02ebf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

turbanoff · 2021-06-22T12:21:00Z

/integrate

openjdk · 2021-06-22T12:22:15Z

@turbanoff
Your change (at version 1168936) is now ready to be sponsored by a Committer.

stsypanov · 2021-06-23T10:05:16Z

/sponsor

openjdk · 2021-06-23T10:06:27Z

@stsypanov Only Committers are allowed to sponsor changes.

bridgekeeper · 2021-07-22T14:00:42Z

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

AlanBateman · 2021-07-23T15:27:25Z

@seanjmullan Are you planning to sponsor this?

seanjmullan · 2021-07-23T17:03:16Z

@seanjmullan Are you planning to sponsor this?

Yes, I can do that, but I will wait until Monday in case there are any post-integration issues that I need to follow up on.

seanjmullan · 2021-07-26T18:17:20Z

/sponsor

openjdk · 2021-07-26T18:19:08Z

Going to push as commit b8f79a7.
Since your change was applied there have been 577 commits pushed to the master branch:

0b12e7c: 8075806: divideExact is missing in java.lang.Math
efa63dc: 8171382: java.time.Duration missing isPositive method
ee55361: 8265474: Dubious 'null' assignment in CompactByteArray.expand
515113d: 8269924: Shenandoah: Introduce weak/strong marking asserts
f2c359a: 8271215: Fix data races in G1PeriodicGCTask
36aefa3: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
e4295cc: 8270519: Move several vector helper methods to shared header file
e627cae: 8270317: Large Allocation in CipherSuite
0dcfc42: Merge
8adf008: 8269984: [macos] JTabbedPane title looks like disabled
... and 567 more: https://git.openjdk.java.net/jdk/compare/5cee23a9ed0b7fe2657be7492d9c1f78fcd02ebf...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-26T18:19:25Z

@seanjmullan @turbanoff Pushed as commit b8f79a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[PATCH] Unnecessary Vector usage in JarIndex.read

b38ee73

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 14, 2021

[PATCH] Unnecessary Vector usage in java.base

1168936

turbanoff changed the title ~~[PATCH] Unnecessary Vector usage in JarIndex.read~~ [PATCH] Unnecessary Vector usage in java.base Jun 14, 2021

openjdk bot added the security security-dev@openjdk.org label Jun 14, 2021

mbien reviewed Jun 15, 2021

View reviewed changes

stsypanov reviewed Jun 16, 2021

View reviewed changes

src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java Show resolved Hide resolved

openjdk bot changed the title ~~[PATCH] Unnecessary Vector usage in java.base~~ 8268873: Unnecessary Vector usage in java.base Jun 16, 2021

openjdk bot added the rfr Pull request is ready for review label Jun 16, 2021

seanjmullan approved these changes Jun 18, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2021

stsypanov mentioned this pull request Jun 22, 2021

8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying #4487

Closed

3 tasks

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 22, 2021

stsypanov approved these changes Jun 22, 2021

View reviewed changes

openjdk bot closed this Jul 26, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 26, 2021

turbanoff deleted the avoid-unnecessary-vector-usage-in-jarindex branch September 15, 2021 07:31

8268873: Unnecessary Vector usage in java.base #4482

8268873: Unnecessary Vector usage in java.base #4482

turbanoff commented Jun 14, 2021 •

edited by openjdk bot

bridgekeeper bot commented Jun 14, 2021

openjdk bot commented Jun 14, 2021

AlanBateman commented Jun 14, 2021

openjdk bot commented Jun 14, 2021

mbien Jun 15, 2021

turbanoff Jun 16, 2021

stsypanov commented Jun 16, 2021

turbanoff commented Jun 16, 2021

openjdk bot commented Jun 16, 2021

mlbridge bot commented Jun 16, 2021

seanjmullan left a comment

openjdk bot commented Jun 18, 2021 •

edited

turbanoff commented Jun 22, 2021

openjdk bot commented Jun 22, 2021

stsypanov commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

bridgekeeper bot commented Jul 22, 2021

AlanBateman commented Jul 23, 2021

seanjmullan commented Jul 23, 2021

seanjmullan commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

8268873: Unnecessary Vector usage in java.base #4482

8268873: Unnecessary Vector usage in java.base #4482

Conversation

turbanoff commented Jun 14, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jun 14, 2021

openjdk bot commented Jun 14, 2021

AlanBateman commented Jun 14, 2021

openjdk bot commented Jun 14, 2021

mbien Jun 15, 2021

Choose a reason for hiding this comment

turbanoff Jun 16, 2021

Choose a reason for hiding this comment

stsypanov commented Jun 16, 2021

turbanoff commented Jun 16, 2021

openjdk bot commented Jun 16, 2021

mlbridge bot commented Jun 16, 2021

Webrevs

seanjmullan left a comment

Choose a reason for hiding this comment

openjdk bot commented Jun 18, 2021 • edited

turbanoff commented Jun 22, 2021

openjdk bot commented Jun 22, 2021

stsypanov commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

bridgekeeper bot commented Jul 22, 2021

AlanBateman commented Jul 23, 2021

seanjmullan commented Jul 23, 2021

seanjmullan commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

turbanoff commented Jun 14, 2021 •

edited by openjdk bot

openjdk bot commented Jun 18, 2021 •

edited