Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268699: Shenandoah: Add test for JDK-8268127 #4486

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jun 14, 2021

Large pages on x86 is 2m and Shenandoah expects >= 10 minimal regions, so heap size has to be < 20m to verify JDK-8268127.

Test:

  • Passed new test on Linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4486/head:pull/4486
$ git checkout pull/4486

Update a local copy of the PR:
$ git checkout pull/4486
$ git pull https://git.openjdk.java.net/jdk pull/4486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4486

View PR using the GUI difftool:
$ git pr show -t 4486

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4486.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 14, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Jun 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 14, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268699: Shenandoah: Add test for JDK-8268127

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 17295b1: Merge
  • b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
  • fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • cce8da2: 8268602: a couple runtime/os tests don't check exit code
  • da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
  • bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/c0b4407d09a7bf9f15553dc5344b1e354b150d57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 14, 2021
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Jun 14, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

Going to push as commit e59acd9.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 17295b1: Merge
  • b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
  • fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • cce8da2: 8268602: a couple runtime/os tests don't check exit code
  • da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
  • bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/c0b4407d09a7bf9f15553dc5344b1e354b150d57...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@zhengyu123 Pushed as commit e59acd9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
2 participants