Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268768: idea.sh has been updated in surprising and incompatible ways #4492

Closed
wants to merge 2 commits into from

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Jun 15, 2021

As the title says (please also refer to the JBS issue which describes all the issues in more details), the IDE support for IntelliJ has been updated with many enhancements as part of a seemingly innocuous "path handling" fix. The IDE doesn't appear to be usable in the same way it was in the past and many functionalities have been broken as a result (including support for jtreg test execution using the plugin).

For the above reasons, I'm reverting the plugin and idea.sh code to last known working version. Any targeted fix can be re-applied after the revert. Larger enhancements need to be discussed in the proper venue:

https://openjdk.java.net/groups/ide-support/


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268768: idea.sh has been updated in surprising and incompatible ways

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4492/head:pull/4492
$ git checkout pull/4492

Update a local copy of the PR:
$ git checkout pull/4492
$ git pull https://git.openjdk.java.net/jdk pull/4492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4492

View PR using the GUI difftool:
$ git pr show -t 4492

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4492.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 15, 2021
@openjdk
Copy link

openjdk bot commented Jun 15, 2021

@mcimadamore The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jun 15, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2021

Webrevs

Copy link
Member

@PaulSandoz PaulSandoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's back up and reevaluate.

@openjdk
Copy link

openjdk bot commented Jun 15, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268768: idea.sh has been updated in surprising and incompatible ways

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • d384093: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • 9f3c7e7: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 2e70bc3: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • e59acd9: 8268699: Shenandoah: Add test for JDK-8268127
  • 17295b1: Merge
  • b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
  • fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/c0b4407d09a7bf9f15553dc5344b1e354b150d57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2021
@jonathan-gibbons
Copy link
Contributor

jonathan-gibbons commented Jun 15, 2021

Does this need backported to 17 (or pushed to 17 and "back"ported into 18)?

@mcimadamore
Copy link
Contributor Author

I can push to 17 if desired, but I'll need a new PR for that

@jonathan-gibbons
Copy link
Contributor

I can push to 17 if desired, but I'll need a new PR for that

pushing to 17 would be nice; the script is equally broken and unusable there.

@mcimadamore
Copy link
Contributor Author

closing - and recreating against 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants