Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268776: Test ADatagramSocket.java missing /othervm from @run tag #4493

Closed
wants to merge 1 commit into from

Conversation

@pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Jun 15, 2021

Hi,

Could someone please review my change to the test test/jdk/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java? The test is missing /othervm from its @run jtreg test tag, which risks polluting other tests that run in that VM.

Currently, any test that runs without /othervm after this test would find the DatagramSocketImpl factory created by this test, and therefore any call made to new DatagramSocket() would return/use a NetMulticastSocket instead of DatagramSocketAdaptor. This could make tests that create DatagramSocket/MulticastSocket fail intermittently in unexplainable ways. Adding in /othervm to the @run tag will avoid this problem.

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4493/head:pull/4493
$ git checkout pull/4493

Update a local copy of the PR:
$ git checkout pull/4493
$ git pull https://git.openjdk.java.net/jdk pull/4493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4493

View PR using the GUI difftool:
$ git pr show -t 4493

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4493.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@pconcannon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the net label Jun 15, 2021
@pconcannon pconcannon closed this Jun 15, 2021
@dfuch
Copy link
Member

@dfuch dfuch commented Jun 15, 2021

Hi Patrick - It would be better to push this to jdk17 - please close this PR and create one against jdk17 repository.

Loading

@pconcannon pconcannon deleted the JDK-8268776 branch Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants