8268780: Use 'print_cr' instead of 'print' for the message 'eliminated <owner is scalar replaced>' #4495

D-D-H · 2021-06-15T17:19:26Z

Hi,

Cound I have a review of this small fix that adds a line feed for the message 'eliminated '.

When we run the following code and run jstack <pid>

    public static void main(String[] args) {
        for (int i = 0; i < 200000000; i++) {
            try {
                test();
            } catch (Exception e) {
            }
        }
    }

    private static void test() throws Exception {
        Object obj = new Object();
        synchronized (obj) {
            throw new Exception();
        }
    }

We could find that a frame that does not wrap properly.

"main" #1 prio=5 os_prio=0 cpu=53202.88ms elapsed=54.10s tid=0x00007f8c2c022550 nid=0x4743 runnable  [0x00007f8c35ac2000]
   java.lang.Thread.State: RUNNABLE
        at java.lang.Throwable.fillInStackTrace(java.base@17-internal/Native Method)
        at java.lang.Throwable.fillInStackTrace(java.base@17-internal/Throwable.java:798)
        - locked <0x00000000f3b00340> (a java.lang.Exception)
        at java.lang.Throwable.<init>(java.base@17-internal/Throwable.java:256)
        at java.lang.Exception.<init>(java.base@17-internal/Exception.java:55)
        at Test.test(Test.java:14)
        - eliminated <owner is scalar replaced> (a java.lang.Object)    at Test.main(Test.java:5)

Also, I noticed that this message has a correct line feed in the implementation of JavaVFrame.java.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8268780: Use 'print_cr' instead of 'print' for the message 'eliminated '

Reviewers

Chris Plummer (@plummercj - Reviewer)
Zhengyu Gu (@zhengyu123 - Reviewer)
Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4495/head:pull/4495
$ git checkout pull/4495

Update a local copy of the PR:
$ git checkout pull/4495
$ git pull https://git.openjdk.java.net/jdk pull/4495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4495

View PR using the GUI difftool:
$ git pr show -t 4495

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4495.diff

…d <owner is scalar replaced>'

bridgekeeper · 2021-06-15T17:20:44Z

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

D-D-H · 2021-06-15T17:23:54Z

/label add hotspot

openjdk · 2021-06-15T17:24:08Z

@D-D-H The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2021-06-15T17:24:25Z

@D-D-H The hotspot label was already applied.

D-D-H · 2021-06-15T17:24:53Z

/label add serviceability

openjdk · 2021-06-15T17:25:46Z

@D-D-H
The serviceability label was successfully added.

mlbridge · 2021-06-15T17:29:50Z

Webrevs

00: Full (97f77ecf)

zhengyu123

Looks good and trivial

openjdk · 2021-06-15T18:39:12Z

@D-D-H This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268780: Use 'print_cr' instead of 'print' for the message 'eliminated <owner is scalar replaced>'

Reviewed-by: cjplummer, zgu, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

e0f6f70: Merge
788b309: 8268768: idea.sh has been updated in surprising and incompatible ways
9ac0609: 8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64
fe7a44d: 8268723: Problem list SA core file tests on OSX when using ZGC
31a055e: 8268736: Use apiNote in AutoCloseable.close javadoc
76cad4b: 8263321: Regression 8% in javadoc-steady in 17-b11
e36136f: 8268125: ZGC: Clone oop array gets wrong acopy stub
35d867d: 8268663: Crash when guards contain boolean expression
4d8b5c7: 8268347: C2: nested locks optimization may create unbalanced monitor enter/exit code
4a6da99: 8268643: SVML lib shouldn't be generated when C2 is absent
... and 8 more: https://git.openjdk.java.net/jdk/compare/0b09129faefb945c2f2c35dab2731961216d054e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @zhengyu123, @dcubed-ojdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

D-D-H · 2021-06-16T01:09:39Z

/integrate

openjdk · 2021-06-16T01:10:42Z

@D-D-H
Your change (at version 97f77ec) is now ready to be sponsored by a Committer.

y1yang0 · 2021-06-16T02:07:22Z

/sponsor

openjdk · 2021-06-16T02:08:46Z

Going to push as commit 48d4562.
Since your change was applied there have been 18 commits pushed to the master branch:

e0f6f70: Merge
788b309: 8268768: idea.sh has been updated in surprising and incompatible ways
9ac0609: 8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64
fe7a44d: 8268723: Problem list SA core file tests on OSX when using ZGC
31a055e: 8268736: Use apiNote in AutoCloseable.close javadoc
76cad4b: 8263321: Regression 8% in javadoc-steady in 17-b11
e36136f: 8268125: ZGC: Clone oop array gets wrong acopy stub
35d867d: 8268663: Crash when guards contain boolean expression
4d8b5c7: 8268347: C2: nested locks optimization may create unbalanced monitor enter/exit code
4a6da99: 8268643: SVML lib shouldn't be generated when C2 is absent
... and 8 more: https://git.openjdk.java.net/jdk/compare/0b09129faefb945c2f2c35dab2731961216d054e...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-06-16T02:09:11Z

@kelthuzadx @D-D-H Pushed as commit 48d4562.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8268780: Use 'print_cr' instead of 'print' for the message 'eliminate…

97f77ec

…d <owner is scalar replaced>'

openjdk bot added the rfr Pull request is ready for review label Jun 15, 2021

openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 15, 2021

openjdk bot added the serviceability serviceability-dev@openjdk.org label Jun 15, 2021

plummercj approved these changes Jun 15, 2021

View reviewed changes

zhengyu123 approved these changes Jun 15, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2021

dcubed-ojdk approved these changes Jun 15, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 16, 2021

openjdk bot closed this Jun 16, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 16, 2021

D-D-H deleted the JDK-8268780 branch June 16, 2021 03:32

D-D-H restored the JDK-8268780 branch June 17, 2021 05:02

D-D-H deleted the JDK-8268780 branch June 17, 2021 05:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8268780: Use 'print_cr' instead of 'print' for the message 'eliminated <owner is scalar replaced>' #4495

8268780: Use 'print_cr' instead of 'print' for the message 'eliminated <owner is scalar replaced>' #4495

Uh oh!

D-D-H commented Jun 15, 2021 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jun 15, 2021

Uh oh!

D-D-H commented Jun 15, 2021

Uh oh!

openjdk bot commented Jun 15, 2021

Uh oh!

openjdk bot commented Jun 15, 2021

Uh oh!

D-D-H commented Jun 15, 2021

Uh oh!

openjdk bot commented Jun 15, 2021

Uh oh!

mlbridge bot commented Jun 15, 2021

Uh oh!

zhengyu123 left a comment

Uh oh!

openjdk bot commented Jun 15, 2021 •

edited

Loading

Uh oh!

D-D-H commented Jun 16, 2021

Uh oh!

openjdk bot commented Jun 16, 2021

Uh oh!

y1yang0 commented Jun 16, 2021

Uh oh!

openjdk bot commented Jun 16, 2021

Uh oh!

openjdk bot commented Jun 16, 2021

Uh oh!

Uh oh!

8268780: Use 'print_cr' instead of 'print' for the message 'eliminated <owner is scalar replaced>' #4495

8268780: Use 'print_cr' instead of 'print' for the message 'eliminated <owner is scalar replaced>' #4495

Uh oh!

Conversation

D-D-H commented Jun 15, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 15, 2021

Uh oh!

D-D-H commented Jun 15, 2021

Uh oh!

openjdk bot commented Jun 15, 2021

Uh oh!

openjdk bot commented Jun 15, 2021

Uh oh!

D-D-H commented Jun 15, 2021

Uh oh!

openjdk bot commented Jun 15, 2021

Uh oh!

mlbridge bot commented Jun 15, 2021

Webrevs

Uh oh!

zhengyu123 left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jun 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

D-D-H commented Jun 16, 2021

Uh oh!

openjdk bot commented Jun 16, 2021

Uh oh!

y1yang0 commented Jun 16, 2021

Uh oh!

openjdk bot commented Jun 16, 2021

Uh oh!

openjdk bot commented Jun 16, 2021

Uh oh!

Uh oh!

D-D-H commented Jun 15, 2021 •

edited by openjdk bot

Loading

openjdk bot commented Jun 15, 2021 •

edited

Loading