Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge jdk17 #4499

Closed
wants to merge 17 commits into from
Closed

Merge jdk17 #4499

wants to merge 17 commits into from

Conversation

JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Jun 15, 2021

Forwardport JDK 17 -> JDK 18


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4499/head:pull/4499
$ git checkout pull/4499

Update a local copy of the PR:
$ git checkout pull/4499
$ git pull https://git.openjdk.java.net/jdk pull/4499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4499

View PR using the GUI difftool:
$ git pr show -t 4499

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4499.diff

Jan Lahoda and others added 17 commits Jun 14, 2021
…case which is not last

Reviewed-by: vromero
Reviewed-by: hseigel, xliu
…enter/exit code

Reviewed-by: roland, vlivanov, dcubed
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2021

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@JesperIRL The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot
  • ide-support
  • javadoc
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc security build hotspot ide-support core-libs compiler labels Jun 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

@JesperIRL
Copy link
Member Author

@JesperIRL JesperIRL commented Jun 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

Going to push as commit e0f6f70.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 00e33a4: 8268647: Generation::expand_and_allocate has unused "parallel" argument

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@JesperIRL Pushed as commit e0f6f70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JesperIRL JesperIRL deleted the forward_port branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build compiler core-libs hotspot ide-support integrated javadoc security
9 participants