Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails #450

Closed
wants to merge 2 commits into from

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Oct 1, 2020

Locally when i run this test i am seeing both the observers getting called and flags are updated.
I suspect this to be an issue with less timeout which we are using for verifying whether observer is getting called or not. Also i have increased sleep time.
I have increased timeout and verified in CI pipeline there is no issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/450/head:pull/450
$ git checkout pull/450

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 1, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2020

@jayathirthrao The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Oct 1, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 1, 2020

Webrevs

mrserb
mrserb approved these changes Oct 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2020

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 7779ce9: 8253689: [s390] Use flag kind "diagnostic" for platform specific flags
  • a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
  • 1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
  • 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 1, 2020
@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Oct 1, 2020

/integrate

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2020

@jayathirthrao Since your change was applied there have been 5 commits pushed to the master branch:

  • 3e96721: 8253727: [cgroups v2] Memory and swap limits reported incorrectly
  • 7779ce9: 8253689: [s390] Use flag kind "diagnostic" for platform specific flags
  • a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
  • 1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
  • 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes

Your commit was automatically rebased without conflicts.

Pushed as commit 928da49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8253739 branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants