8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"

[dholmes-ora]

Please review this trivial fix to add a missing "static" to a function prototype. For some reason VS 16.9.3+ doesn't treat this as an error but earlier versions do (and gcc/g++ confirms).

Tested our CI builds remain okay with this change.

Thanks,
David

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4516/head:pull/4516
$ git checkout pull/4516

Update a local copy of the PR:
$ git checkout pull/4516
$ git pull https://git.openjdk.java.net/jdk pull/4516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4516

View PR using the GUI difftool:
$ git pr show -t 4516

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4516.diff

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (60887bb5)

[tstuefe]

Looks good and trivial.

..Thomas

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 3637e50: Merge
• 9f7851b: 8260194: Update the documentation for -Xcheck:jni
• ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
• f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
• 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
• 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
• 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
• 38dbe05: 8268901: JDK-8268768 missed removing two files
• 9ad19f7: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
• 19f5fab: 8268861: Disable Windows-Aarch64 build in GitHub Actions
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/02c9bf087e50885bbc8028415c4e674947ee7a16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks Thomas!

/integrate

[openjdk]

Going to push as commit e844610.
Since your change was applied there have been 14 commits pushed to the master branch:

• 3637e50: Merge
• 9f7851b: 8260194: Update the documentation for -Xcheck:jni
• ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
• f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
• 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
• 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
• 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
• 38dbe05: 8268901: JDK-8268768 missed removing two files
• 9ad19f7: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
• 19f5fab: 8268861: Disable Windows-Aarch64 build in GitHub Actions
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/02c9bf087e50885bbc8028415c4e674947ee7a16...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit e844610.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.