Skip to content

8268900: com/sun/net/httpserver/Headers.java: Fix indentation and whitespace #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jun 17, 2021

This cleanup-only change fixes the indentation of all members from 8 to 4 spaces and removes whitespace in method invocations (example: foo () -> foo()). It also removes superfluous type parameters on lines 83, 168, 206.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268900: com/sun/net/httpserver/Headers.java: Fix indentation and whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4517/head:pull/4517
$ git checkout pull/4517

Update a local copy of the PR:
$ git checkout pull/4517
$ git pull https://git.openjdk.java.net/jdk pull/4517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4517

View PR using the GUI difftool:
$ git pr show -t 4517

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4517.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2021

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2021
@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jun 17, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268900: com/sun/net/httpserver/Headers.java: Fix indentation and whitespace

Reviewed-by: dfuchs, chegar, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 2d088fa: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • e844610: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • 3637e50: Merge
  • 9f7851b: 8260194: Update the documentation for -Xcheck:jni
  • ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
  • f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
  • 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
  • 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
  • 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
  • 38dbe05: 8268901: JDK-8268768 missed removing two files
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/72b3b0af08136342e54e1cdea0c48d64172e8870...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2021
@FrauBoes
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2021

Going to push as commit f4d20b2.
Since your change was applied there have been 37 commits pushed to the master branch:

  • a051e73: Merge
  • 9130b8a: 8268371: C2: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
  • 8545269: 8268676: assert(!ik->is_interface() && !ik->has_subklass()) failed: inconsistent klass hierarchy
  • c98d508: 8268265: MutableSpaceUsedHelper::take_sample() hits assert(left >= right) failed: avoid overflow
  • b66001a: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64
  • 0011b52: 8264843: Javac crashes with NullPointerException when finding unencoded XML in
     tag
  • 2047da7: 8265297: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with "RuntimeException: java.net.SocketException: Connection reset"
  • 091bc4a: 8268353: Test libsvml.so is and is not present in jdk image
  • 69d01b6: 8249899: jdk/javadoc/tool/InlineTagsWithBraces.java uses @ignore w/o bug-id
  • 7d7bdbe: 8268776: Test ADatagramSocket.java missing /othervm from @run tag
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/72b3b0af08136342e54e1cdea0c48d64172e8870...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2021
@openjdk
Copy link

openjdk bot commented Jun 18, 2021

@FrauBoes Pushed as commit f4d20b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@FrauBoes FrauBoes deleted the 8268900 branch June 18, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants