Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268964: Remove unused ReferenceProcessorAtomicMutator #4519

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 17, 2021

Simple change of removing an unused class and a method solely used by it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268964: Remove unused ReferenceProcessorAtomicMutator

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4519/head:pull/4519
$ git checkout pull/4519

Update a local copy of the PR:
$ git checkout pull/4519
$ git pull https://git.openjdk.java.net/jdk pull/4519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4519

View PR using the GUI difftool:
$ git pr show -t 4519

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4519.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 17, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 17, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268964: Remove unused ReferenceProcessorAtomicMutator

Reviewed-by: tschatzl, pliden

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f2afe0a: 8268556: Use bitmap for storing regions that failed evacuation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 17, 2021
pliden
pliden approved these changes Jun 17, 2021
@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 17, 2021

Please add a verb like "Remove" to the title of this CR before pushing.

@albertnetymk albertnetymk changed the title 8268964: Unused ReferenceProcessorAtomicMutator 8268964: Remove unused ReferenceProcessorAtomicMutator Jun 17, 2021
@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jun 18, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

Going to push as commit 5ae9a12.
Since your change was applied there have been 18 commits pushed to the master branch:

  • f4d20b2: 8268900: com/sun/net/httpserver/Headers.java: Fix indentation and whitespace
  • a051e73: Merge
  • 9130b8a: 8268371: C2: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
  • 8545269: 8268676: assert(!ik->is_interface() && !ik->has_subklass()) failed: inconsistent klass hierarchy
  • c98d508: 8268265: MutableSpaceUsedHelper::take_sample() hits assert(left >= right) failed: avoid overflow
  • b66001a: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64
  • 0011b52: 8264843: Javac crashes with NullPointerException when finding unencoded XML in
     tag
  • 2047da7: 8265297: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with "RuntimeException: java.net.SocketException: Connection reset"
  • 091bc4a: 8268353: Test libsvml.so is and is not present in jdk image
  • 69d01b6: 8249899: jdk/javadoc/tool/InlineTagsWithBraces.java uses @ignore w/o bug-id
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/2d088fa91d18252a801db3b84ff87e261d63ebd4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@albertnetymk Pushed as commit 5ae9a12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the atomic-discovery branch Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants