Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired #4524

Closed
wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jun 17, 2021

See the bug for more details.

  • Intermediate root cert R3 doesn't specify OCSP responder and end entity test certificates doesn't specify CRLs
  • New test artifacts are available but revoked expires on July 7th, 2021 and valid on August 31st, 2021. so backdated validity check is performed for OCSP.

If this fix is not acceptable for now then we can wait till CA updates test sites.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4524/head:pull/4524
$ git checkout pull/4524

Update a local copy of the PR:
$ git checkout pull/4524
$ git pull https://git.openjdk.java.net/jdk pull/4524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4524

View PR using the GUI difftool:
$ git pr show -t 4524

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4524.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2021
@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 17, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 18, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2021
@rhalade
Copy link
Member Author

rhalade commented Jun 18, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2021

Going to push as commit 58e6e6d.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2021
@openjdk
Copy link

openjdk bot commented Jun 18, 2021

@rhalade Pushed as commit 58e6e6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8268678 branch June 18, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants