Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268952: Automatically update heap sizes in G1MonitoringScope #4529

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 18, 2021

Hi,

can I have reviews to factor out the call to G1MonitoringScope::update_sizes() into the destructor of that class? Currently all users seem to call this manually close to the end of the scope G1MonitoringScope is in.

Testing: tier1-5

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268952: Automatically update heap sizes in G1MonitoringScope

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4529/head:pull/4529
$ git checkout pull/4529

Update a local copy of the PR:
$ git checkout pull/4529
$ git pull https://git.openjdk.java.net/jdk pull/4529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4529

View PR using the GUI difftool:
$ git pr show -t 4529

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4529.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 18, 2021
@tschatzl tschatzl marked this pull request as ready for review Jun 18, 2021
@openjdk openjdk bot added the rfr label Jun 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 19, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268952: Automatically update heap sizes in G1MonitoringScope

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 19, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jun 21, 2021

Thanks @kimbarrett for your review.

Copy link
Member

@walulyai walulyai left a comment

lgtm!

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jun 21, 2021

Thanks @kimbarrett @walulyai for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

Going to push as commit a58c477.
Since your change was applied there have been 46 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@tschatzl Pushed as commit a58c477.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8268952-automatically-update-g1monitoringscope branch Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants