Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6646602: Spelling error in javadoc for javax.swing.tree.TreeModel #453

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 1, 2020

Fixed a typo in the documentation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-6646602: Spelling error in javadoc for javax.swing.tree.TreeModel

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/453/head:pull/453
$ git checkout pull/453

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Oct 1, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

6646602: Spelling error in javadoc for javax.swing.tree.TreeModel

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

  • dd36d8c: 8253429: Error reporting should report correct state of terminated/aborted threads
  • 2d9fa9d: 8247912: Make narrowOop a scoped enum
  • 928da49: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails
  • 3e96721: 8253727: [cgroups v2] Memory and swap limits reported incorrectly
  • 7779ce9: 8253689: [s390] Use flag kind "diagnostic" for platform specific flags
  • a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
  • 1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
  • 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
  • 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
  • 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
  • ... and 84 more: https://git.openjdk.java.net/jdk/compare/dcde95ba0d68a3aa3f2f405c6141d645a52c28e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2020
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Oct 1, 2020

/integrate

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@prsadhuk Since your change was applied there have been 95 commits pushed to the master branch:

  • 87276bc: 6690021: typos in TransferHandler Javadoc
  • dd36d8c: 8253429: Error reporting should report correct state of terminated/aborted threads
  • 2d9fa9d: 8247912: Make narrowOop a scoped enum
  • 928da49: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails
  • 3e96721: 8253727: [cgroups v2] Memory and swap limits reported incorrectly
  • 7779ce9: 8253689: [s390] Use flag kind "diagnostic" for platform specific flags
  • a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
  • 1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
  • 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
  • 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/dcde95ba0d68a3aa3f2f405c6141d645a52c28e4...master

Your commit was automatically rebased without conflicts.

Pushed as commit ed62b01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-6646602 branch October 5, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants