Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269029: compiler/codegen/TestCharVect2.java fails for client VMs #4530

Closed
wants to merge 2 commits into from

Conversation

mychris
Copy link
Member

@mychris mychris commented Jun 18, 2021

This reverts parts of the changes done by 7320e05.

The introduced CompileCommand is still present, but the test case is again split up into two parts, one generic (without the MaxVectorSize flag), and one C2 specific with that flag. This fixes the test case for C1.

We could also keep the current test structure and add IgnoreUnrecognizedVMOptions for the later three runs, but this would execute the same test case multiple times if a client VM is tested.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269029: compiler/codegen/TestCharVect2.java fails for client VMs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4530/head:pull/4530
$ git checkout pull/4530

Update a local copy of the PR:
$ git checkout pull/4530
$ git pull https://git.openjdk.java.net/jdk pull/4530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4530

View PR using the GUI difftool:
$ git pr show -t 4530

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4530.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@mychris The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jun 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Jun 18, 2021

The change looks reasonable to me.
Please also update the copyright year.
Thanks.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269029: compiler/codegen/TestCharVect2.java fails for client VMs

Reviewed-by: kvn, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 18, 2021
Copy link
Member

@DamonFool DamonFool left a comment

LGTM.
Thanks for your update.

@mychris
Copy link
Member Author

@mychris mychris commented Jun 21, 2021

Thanks for the reviews.
/integrate

@openjdk openjdk bot added the sponsor label Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@mychris
Your change (at version 23ec9a3) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Jun 21, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

Going to push as commit cbec37d.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@DamonFool @mychris Pushed as commit cbec37d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants