8269029: compiler/codegen/TestCharVect2.java fails for client VMs

[mychris]

This reverts parts of the changes done by 7320e05.

The introduced CompileCommand is still present, but the test case is again split up into two parts, one generic (without the MaxVectorSize flag), and one C2 specific with that flag. This fixes the test case for C1.

We could also keep the current test structure and add IgnoreUnrecognizedVMOptions for the later three runs, but this would execute the same test case multiple times if a client VM is tested.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269029: compiler/codegen/TestCharVect2.java fails for client VMs

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to b6fa971
• Jie Fu (@DamonFool - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4530/head:pull/4530
$ git checkout pull/4530

Update a local copy of the PR:
$ git checkout pull/4530
$ git pull https://git.openjdk.java.net/jdk pull/4530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4530

View PR using the GUI difftool:
$ git pr show -t 4530

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4530.diff

[bridgekeeper]

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mychris The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (23ec9a30)
• 00: Full (b6fa971d)

[DamonFool]

The change looks reasonable to me.
Please also update the copyright year.
Thanks.

[vnkozlov]

Trivial.

[openjdk]

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269029: compiler/codegen/TestCharVect2.java fails for client VMs

Reviewed-by: kvn, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 1692fd2: 8017163: G1: Refactor remembered sets
• 0b8a0e2: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
• b7d78a5: Merge
• b8f073b: 8268316: Typo in JFR jdk.Deserialization event
• b9d7337: 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting.
• 8caeca0: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
• 7e03cf2: 8265073: XML transformation and indentation when using xml:space
• 60389ee: 8269025: jsig/Testjsig.java doesn't check exit code
• dab00ee: 8266518: Refactor and expand scatter/gather tests
• f9c8c1c: 8268903: JFR: RecordingStream::dump is missing @SInCE
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/5ae9a12858a20361c163e1dfe6b67970f27e4e40...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[DamonFool]

LGTM.
Thanks for your update.

[mychris]

Thanks for the reviews.
/integrate

[openjdk]

@mychris
Your change (at version 23ec9a3) is now ready to be sponsored by a Committer.

[DamonFool]

/sponsor

[openjdk]

Going to push as commit cbec37d.
Since your change was applied there have been 26 commits pushed to the master branch:

• 1692fd2: 8017163: G1: Refactor remembered sets
• 0b8a0e2: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
• b7d78a5: Merge
• b8f073b: 8268316: Typo in JFR jdk.Deserialization event
• b9d7337: 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting.
• 8caeca0: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
• 7e03cf2: 8265073: XML transformation and indentation when using xml:space
• 60389ee: 8269025: jsig/Testjsig.java doesn't check exit code
• dab00ee: 8266518: Refactor and expand scatter/gather tests
• f9c8c1c: 8268903: JFR: RecordingStream::dump is missing @SInCE
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/5ae9a12858a20361c163e1dfe6b67970f27e4e40...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool @mychris Pushed as commit cbec37d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.