Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection #4532

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Jun 18, 2021

Main logic of the tests is:

TestProcessLauncher t = ...;
try {
t.launch();
.. perform testing ...
} finally {
t.quit();
}

We have some problem with the tests, but the exception from TestProcessLauncher.quit() masks it.
The failures are very intermittent, so need to fix this excption to get more information about real error.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4532/head:pull/4532
$ git checkout pull/4532

Update a local copy of the PR:
$ git checkout pull/4532
$ git pull https://git.openjdk.java.net/jdk pull/4532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4532

View PR using the GUI difftool:
$ git pr show -t 4532

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4532.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Jun 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

  • f375916: 8269186: [REDO] Remove CodeCache::mark_for_evol_deoptimization() method
  • 7621fa3: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
  • f3ba269: 8256306: ObjectMonitor::_contentions field should not be 'jint'
  • 52d5d1b: 8269188: [BACKOUT] Remove CodeCache::mark_for_evol_deoptimization() method
  • f2e690e: 8268720: Unspecified checks on NameAndType constants should not be performed
  • 2c29d79: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • 6237630: 8269120: Build failure with GCC 6.3.0 after JDK-8017163
  • a5e4307: 8269134: Remove sparsePRT.inline.hpp after JDK-8017163
  • 17daf32: 8269138: Move typeArrayOop.inline.hpp include to vectorSupport.cpp
  • 36d82b6: 8268858: Determine register pressure automatically by the number of available registers for allocation
  • ... and 73 more: https://git.openjdk.java.net/jdk/compare/f2afe0a5130fd3162403ecc18c827bcf56e9c883...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 22, 2021
@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Jun 23, 2021

Ping. Need 2nd reviewer

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 23, 2021

Doesn't this just result in seeing a WARNING message instead of the failure described in JDK-8268433? Or do you still expect the test to fail, but to give other useful information.

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Jun 23, 2021

Doesn't this just result in seeing a WARNING message instead of the failure described in JDK-8268433? Or do you still expect the test to fail, but to give other useful information.

Yes, I expect that the tests continue to fail, but with this fix we should see real error.

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Jun 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

Going to push as commit 280f2d5.
Since your change was applied there have been 83 commits pushed to the master branch:

  • f375916: 8269186: [REDO] Remove CodeCache::mark_for_evol_deoptimization() method
  • 7621fa3: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
  • f3ba269: 8256306: ObjectMonitor::_contentions field should not be 'jint'
  • 52d5d1b: 8269188: [BACKOUT] Remove CodeCache::mark_for_evol_deoptimization() method
  • f2e690e: 8268720: Unspecified checks on NameAndType constants should not be performed
  • 2c29d79: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • 6237630: 8269120: Build failure with GCC 6.3.0 after JDK-8017163
  • a5e4307: 8269134: Remove sparsePRT.inline.hpp after JDK-8017163
  • 17daf32: 8269138: Move typeArrayOop.inline.hpp include to vectorSupport.cpp
  • 36d82b6: 8268858: Determine register pressure automatically by the number of available registers for allocation
  • ... and 73 more: https://git.openjdk.java.net/jdk/compare/f2afe0a5130fd3162403ecc18c827bcf56e9c883...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@alexmenkov Pushed as commit 280f2d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the IOPipe_quit branch Jun 24, 2021
@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 24, 2021

@alexmenkov - please see the new bug I just filed:

JDK-8269302 serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433

Hopefully this new sighting has the info you are looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants