Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest #4538

Closed
wants to merge 1 commit into from

Conversation

stefank
Copy link
Member

@stefank stefank commented Jun 21, 2021

The invocation that runs with large pages are guarded with @require vm.gc.G1 and doesn't explicitly state that G1 should be used.

This means two things:

  1. We are not running the large pages subtest when other GCs are specified
  2. Under some circumstances another GC is ergonomically selected and we run the test with that GC even though the test was guarded by @require vm.gc.G1.

I propose that we move the subtest to its own run section, without any requirement about the used GC.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4538/head:pull/4538
$ git checkout pull/4538

Update a local copy of the PR:
$ git checkout pull/4538
$ git pull https://git.openjdk.java.net/jdk pull/4538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4538

View PR using the GUI difftool:
$ git pr show -t 4538

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4538.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 21, 2021

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@stefank The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 21, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@stefank stefank changed the title 8269077: TestSystemGC uses @require vm.gc.G1 for large pages subtest 8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • cd20c01: 8268458: Add verification type for evacuation failures
  • a58c477: 8268952: Automatically update heap sizes in G1MonitoringScope
  • cbec37d: 8269029: compiler/codegen/TestCharVect2.java fails for client VMs
  • 1692fd2: 8017163: G1: Refactor remembered sets
  • 0b8a0e2: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 21, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@stefank
Copy link
Member Author

@stefank stefank commented Jun 22, 2021

Thanks for reviewing!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

Going to push as commit 1a81815.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 0458113: Merge
  • d3ad8cd: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • f25e719: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails
  • 22ebd19: 8268362: [REDO] C2 crash when compile negative Arrays.copyOf length after loop
  • f8df953: 8268702: JFR diagnostic commands lack argument descriptors when viewed using Platform MBean Server
  • c294ae4: 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header
  • b358b54: 8269063: Build failure due to VerifyReceiverTypes was not declared after JDK-8268405
  • cd20c01: 8268458: Add verification type for evacuation failures
  • a58c477: 8268952: Automatically update heap sizes in G1MonitoringScope
  • cbec37d: 8269029: compiler/codegen/TestCharVect2.java fails for client VMs
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/b7d78a5b661e2b00f271298db3b6cc873cf754e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@stefank Pushed as commit 1a81815.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stefank stefank deleted the 8269077_TestSystemGC_require branch Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants