Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269022: Put evacuation failure string directly into gc=info log message #4539

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 21, 2021

Hi all,

can I have reviews for this change that puts the evacuation failure marker from a separate log line into the GC timing message. I.e. instead of

Pause Young (Normal) (G1 Evacuation Pause)
To-space exhausted

into

Pause Young (Normal) (Evacuation Failure) (G1 Evacuation Pause) 

This is imho easier to read, better to process and less wasteful with log space.

Testing: tier1, gc/g1 tests


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269022: Put evacuation failure string directly into gc=info log message

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4539/head:pull/4539
$ git checkout pull/4539

Update a local copy of the PR:
$ git checkout pull/4539
$ git pull https://git.openjdk.java.net/jdk pull/4539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4539

View PR using the GUI difftool:
$ git pr show -t 4539

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4539.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 21, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 21, 2021
@tschatzl tschatzl marked this pull request as ready for review Jun 21, 2021
@openjdk openjdk bot added the rfr label Jun 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 21, 2021

Webrevs

Copy link
Contributor

@lkorinth lkorinth left a comment

I have some comments, but otherwise it looks good to me.

src/hotspot/share/gc/g1/g1CollectedHeap.cpp Show resolved Hide resolved
test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java Outdated Show resolved Hide resolved
src/hotspot/share/gc/g1/g1CollectedHeap.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@lkorinth lkorinth left a comment

Still looks good to me!

Copy link
Member

@albertnetymk albertnetymk left a comment

Regarding Pause Young (Normal) (Evacuation Failure) (G1 Evacuation Pause), I interpret the three pairs of parens as:

1. (<gc pause kind, deciding what should be done in this pause>)
2. (<sth unexpected happened, deviating from the original plan>)
3. (<what initiates this pause>)

2 occurs strictly later than 1&3, so a more natural order is

Pause Young (Normal) (G1 Evacuation Pause) (Evacuation Failure).

This way, the original structure (meaning of the first two pairs of parens) could be preserved in all cases. When sth unexpected happens, the log is only appended, leaving the "conceptually existing" part intact.

Ofc, this is very subjective; just my 2 cents. (Merely a comment, not a review. I am fine with the current change.)

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jul 6, 2021

I am aware of this and this has come up before. The problem is that the order of adding these strings is fixed by the execution order of the scoped objects. My initial attempt to fix this was too messy, but 'll look into this again, maybe I can find some better way.

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jul 6, 2021

@albertnetymk : fixed :)

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

I agreed with Albert's comment about the order of the annotations. I'm glad you found a (nice, not kludgy) way to fix that.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269022: Put evacuation failure string directly into gc=info log message

Reviewed-by: iwalulya, lkorinth, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 4dfcf53: 8269935: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on windows
  • 1578979: 8269917: Insert missing commas in copyrights in java.net
  • 326b2e1: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation
  • f485171: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE
  • 16aa8cb: 8269697: JNI_GetPrimitiveArrayCritical() should not accept object array
  • e47803a: 8266310: deadlock between System.loadLibrary and JNI FindClass loading another class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 6, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jul 7, 2021

Thanks @albertnetymk @walulyai @lkorinth @kimbarrett for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

Going to push as commit a685011.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 72530ef: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events
  • 3d090e7: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • a9e2010: 8268425: Show decimal nid of OSThread instead of hex format one
  • 01c29d8: 8266407: remove jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES
  • 7a4f08a: Merge
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/20eba35515073c4daf1fa8ac78a37196ea196690...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@tschatzl Pushed as commit a685011.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8269022-evac-failure-string-in-gc-info-message branch Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
5 participants