8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure

[tschatzl]

Hi all,

can I have reviews for this change to the jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java test to use the only "officially sanctioned" way to cause evacuation failures via the respective debug-level options.

Testing: checking failing test case to cause evacuation failures

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Ivan Walulya (@walulyai - Committer)
• Albert Mingkun Yang (@albertnetymk - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4541/head:pull/4541
$ git checkout pull/4541

Update a local copy of the PR:
$ git checkout pull/4541
$ git pull https://git.openjdk.java.net/jdk pull/4541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4541

View PR using the GUI difftool:
$ git pr show -t 4541

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4541.diff

[tschatzl]

/label add hotspot-gc

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (e4780d3b)
• 00: Full (fcf922c0)

[kimbarrett]

Looks good.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure

Reviewed-by: kbarrett, iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

• 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
• b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
• ee526a2: Merge
• 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
• d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
• 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
• b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
• 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
• 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127
• 7010dfd: 8269517: compiler/loopopts/TestPartialPeelingSinkNodes.java crashes with -XX:+VerifyGraphEdges
• ... and 113 more: https://git.openjdk.java.net/jdk/compare/cd20c01942dd8559a31e51ef2a595c6eba44b8ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[walulyai]

lgtm!

[tschatzl]

Thanks @kimbarrett @walulyai @albertnetymk for your reviews.

/integrate

[openjdk]

Going to push as commit ee0247f.
Since your change was applied there have been 123 commits pushed to the master branch:

• 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
• b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
• ee526a2: Merge
• 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
• d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
• 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
• b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
• 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
• 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127
• 7010dfd: 8269517: compiler/loopopts/TestPartialPeelingSinkNodes.java crashes with -XX:+VerifyGraphEdges
• ... and 113 more: https://git.openjdk.java.net/jdk/compare/cd20c01942dd8559a31e51ef2a595c6eba44b8ad...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit ee0247f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.