Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268664: The documentation of the Scanner.hasNextLine is incorrect #4547

Closed
wants to merge 1 commit into from

Conversation

@igraves
Copy link
Member

@igraves igraves commented Jun 22, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268664: The documentation of the Scanner.hasNextLine is incorrect

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4547/head:pull/4547
$ git checkout pull/4547

Update a local copy of the PR:
$ git checkout pull/4547
$ git pull https://git.openjdk.java.net/jdk pull/4547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4547

View PR using the GUI difftool:
$ git pr show -t 4547

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4547.diff

@igraves
Copy link
Member Author

@igraves igraves commented Jun 22, 2021

/csr

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2021

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the csr label Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@igraves this pull request will not be integrated until the CSR request JDK-8269099 for issue JDK-8268664 has been approved.

Loading

@openjdk openjdk bot added the rfr label Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@igraves The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jun 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2021

Webrevs

Loading

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

LGTM

Loading

bplb
bplb approved these changes Jun 22, 2021
Copy link
Member

@bplb bplb left a comment

+1

Loading

Copy link
Member

@irisclark irisclark left a comment

Associated CSR also Reviewed.

Loading

@openjdk openjdk bot removed the csr label Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268664: The documentation of the Scanner.hasNextLine is incorrect

Reviewed-by: rriggs, bpb, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 176 new commits pushed to the master branch:

  • cb79589: 8188046: java.lang.Math.mutliplyHigh does not run in constant time
  • ca4bea4: 8188044: We need Math.unsignedMultiplyHigh
  • 3d84398: 8268364: jmethod clearing should be done during unloading
  • 53ad903: 8269135: TestDifferentProtectionDomains runs into timeout in client VM
  • f8bcbf0: 8269596: Snapshot soft ref policy before marking/copying
  • 4107dcf: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads
  • 2baf498: 8269743: test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/jni/nativeAndMH/Test.java crash with small heap (-Xmx50m)
  • 589f084: 8269110: ZGC: Remove dead code in zBarrier
  • b0e1867: Merge
  • a4d2a9a: 8269745: [JVMCI] restore original qualified exports to Graal
  • ... and 166 more: https://git.openjdk.java.net/jdk/compare/cd20c01942dd8559a31e51ef2a595c6eba44b8ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 2, 2021
@igraves
Copy link
Member Author

@igraves igraves commented Jul 2, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

Going to push as commit 0d0f6a4.
Since your change was applied there have been 176 commits pushed to the master branch:

  • cb79589: 8188046: java.lang.Math.mutliplyHigh does not run in constant time
  • ca4bea4: 8188044: We need Math.unsignedMultiplyHigh
  • 3d84398: 8268364: jmethod clearing should be done during unloading
  • 53ad903: 8269135: TestDifferentProtectionDomains runs into timeout in client VM
  • f8bcbf0: 8269596: Snapshot soft ref policy before marking/copying
  • 4107dcf: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads
  • 2baf498: 8269743: test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/jni/nativeAndMH/Test.java crash with small heap (-Xmx50m)
  • 589f084: 8269110: ZGC: Remove dead code in zBarrier
  • b0e1867: Merge
  • a4d2a9a: 8269745: [JVMCI] restore original qualified exports to Graal
  • ... and 166 more: https://git.openjdk.java.net/jdk/compare/cd20c01942dd8559a31e51ef2a595c6eba44b8ad...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@igraves Pushed as commit 0d0f6a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants