Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269124: Update java.time to use switch expressions (part II) #4552

Closed
wants to merge 7 commits into from

Conversation

pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Jun 22, 2021

Hi,

Could someone please review the second half of my update for the java.time package to make use of switch expressions?

This PR was split into two parts due to the large number of files affected.

Kind regards,

Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269124: Update java.time to use switch expressions (part II)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4552/head:pull/4552
$ git checkout pull/4552

Update a local copy of the PR:
$ git checkout pull/4552
$ git pull https://git.openjdk.java.net/jdk pull/4552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4552

View PR using the GUI difftool:
$ git pr show -t 4552

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4552.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@pconcannon The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs i18n labels Jun 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2021

Webrevs

dfuch
dfuch approved these changes Jun 22, 2021
Copy link
Member

@dfuch dfuch left a comment

The proposed changes look reasonable to me. Make sure to run all the tests of course.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269124: Update java.time to use switch expressions (part II)

Reviewed-by: dfuchs, vtewari, aefimov, iris, lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 22, 2021
Copy link
Contributor

@vyommani vyommani left a comment

Changes looks OK to me, although i can see, in existing code couple of places we are doing conversion from long to int((int) newValue * 1000_000;)

Copy link
Member

@AlekseiEfimov AlekseiEfimov left a comment

Thanks for quickly addressing the issues.
The latest version looks good to me.

naotoj
naotoj approved these changes Jun 23, 2021
dfuch
dfuch approved these changes Jun 24, 2021
naotoj
naotoj approved these changes Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

⚠️ @pconcannon This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@pconcannon
Copy link
Contributor Author

@pconcannon pconcannon commented Jul 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

Going to push as commit 8a7b380.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 675a952: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work
  • 4da52ea: 8269004: Implement ResizableResourceHashtable
  • 390d102: 8269652: Factor out the common code for creating system j.l.Thread objects
  • 17f53f2: Merge
  • 1c18f91: 8269768: JFR Terminology Refresh
  • 6f0e8e7: 8269775: compiler/codegen/ClearArrayTest.java failed with "assert(false) failed: bad AD file"
  • c4ea13e: 8269543: The warning for System::setSecurityManager should only appear once for each caller
  • 2db9005: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 7bc96db: 8269771: assert(tmp == _callprojs.fallthrough_catchproj) failed: allocation control projection
  • 5644c4f: 8265132: C2 compilation fails with assert "missing precedence edge"
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/f8bcbf0172af25ac17b110d22232bd618cfd621a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

@pconcannon Pushed as commit 8a7b380.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pconcannon pconcannon deleted the JDK-8269124 branch Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs i18n integrated
7 participants