Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268967: Update java.security to use switch expressions #4553

Closed
wants to merge 3 commits into from

Conversation

pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Jun 22, 2021

Hi,

Could someone please review my code for updating the code in the java.security packages to make use of the switch expressions?

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268967: Update java.security to use switch expressions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4553/head:pull/4553
$ git checkout pull/4553

Update a local copy of the PR:
$ git checkout pull/4553
$ git pull https://git.openjdk.java.net/jdk pull/4553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4553

View PR using the GUI difftool:
$ git pr show -t 4553

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4553.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 22, 2021
@openjdk
Copy link

openjdk bot commented Jun 22, 2021

@pconcannon The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2021

Webrevs

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the nice update.

@openjdk
Copy link

openjdk bot commented Jun 22, 2021

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268967: Update java.security to use switch expressions

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2021
@pconcannon
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2021

Going to push as commit 35c4702.
Since your change was applied there have been 2 commits pushed to the master branch:

  • b565459: 8267138: Stray suffix when starting gtests via GTestWrapper.java
  • 1d16797: 8268469: Update java.time to use switch expressions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2021
@openjdk
Copy link

openjdk bot commented Jun 25, 2021

@pconcannon Pushed as commit 35c4702.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pconcannon pconcannon deleted the JDK-8268967 branch July 6, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants