New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268967: Update java.security to use switch expressions #4553
Conversation
|
@pconcannon The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the nice update.
@pconcannon This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Going to push as commit 35c4702.
Your commit was automatically rebased without conflicts. |
@pconcannon Pushed as commit 35c4702. |
Hi,
Could someone please review my code for updating the code in the
java.security
packages to make use of the switch expressions?Kind regards,
Patrick
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4553/head:pull/4553
$ git checkout pull/4553
Update a local copy of the PR:
$ git checkout pull/4553
$ git pull https://git.openjdk.java.net/jdk pull/4553/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4553
View PR using the GUI difftool:
$ git pr show -t 4553
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4553.diff