Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'" #4560

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Jun 22, 2021

Updated AllModulesCommandTest to use dynamic port launching debuggee.
Parsing debuggee listening address functionality is required in several tests (and we have other tests which need to be fixed the same way), so moved the code to new class in jdk.test.lib


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4560/head:pull/4560
$ git checkout pull/4560

Update a local copy of the PR:
$ git checkout pull/4560
$ git pull https://git.openjdk.java.net/jdk pull/4560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4560

View PR using the GUI difftool:
$ git pr show -t 4560

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4560.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 22, 2021
@openjdk
Copy link

openjdk bot commented Jun 22, 2021

@alexmenkov The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability core-libs labels Jun 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2021

Webrevs

@alexmenkov
Copy link
Author

alexmenkov commented Jun 22, 2021

/label remove core-libs

@openjdk openjdk bot removed the core-libs label Jun 22, 2021
@openjdk
Copy link

openjdk bot commented Jun 22, 2021

@alexmenkov
The core-libs label was successfully removed.

@alexmenkov
Copy link
Author

alexmenkov commented Jun 28, 2021

Ping

// m.group(1) is transport, m.group(2) is port
return Integer.parseInt(m.group(2));
JDWP.ListenAddress addr = JDWP.parseListenAddress(s);
if (addr != null) {
Copy link
Contributor

@sspitsyn sspitsyn Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going to happen in the case of addr == null?

Copy link
Author

@alexmenkov alexmenkov Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addr == null means we didn't get "listening for transport" output yet.
We continue to run the loop waiting for the parse-able output

Copy link
Contributor

@sspitsyn sspitsyn left a comment

It looks good to me. Just one minor question inlined.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'"

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

  • a977157: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • ee1e202: 8268821: Split systemDictionaryShared.cpp
  • 03d54e6: Merge
  • 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes
  • 8d09596: 8269304: Regression ~5% in 2005 in b27
  • e4c5446: 8268236: The documentation of the String.regionMatches method contains error
  • e9b2c05: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
  • ... and 123 more: https://git.openjdk.java.net/jdk/compare/8f2456e5b058a88730ec383d88634737849afdfb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 28, 2021
@kevinjwalls
Copy link

kevinjwalls commented Jun 29, 2021

OK, so we let the debugee JVM find its own port, and start using it, then JDWP.parseListenAddress() decodes the debugee output to find the port in use. findFreePort used previously was not working well, or was racing with other tests and clashing. Sounds good.

I'm not sure in Debugee.java why we use an array for: JDWP.ListenAddress[] listenAddress

@alexmenkov
Copy link
Author

alexmenkov commented Jun 29, 2021

I'm not sure in Debugee.java why we use an array for: JDWP.ListenAddress[] listenAddress

We set the value of the local variable in lambda, so the variable must be final or (as in this case) effectively final

@alexmenkov
Copy link
Author

alexmenkov commented Jun 29, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 29, 2021

Going to push as commit 7a23c9c.
Since your change was applied there have been 137 commits pushed to the master branch:

  • c1e2a29: 8263640: hs_err improvement: handle class path longer than O_BUFLEN
  • bb42d75: 8269417: Minor clarification on NonblockingQueue utility
  • e238cbd: 8269530: runtime/ParallelLoad/ParallelSuperTest.java timeout
  • 3f2c372: 8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC
  • a977157: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • ee1e202: 8268821: Split systemDictionaryShared.cpp
  • 03d54e6: Merge
  • 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • ... and 127 more: https://git.openjdk.java.net/jdk/compare/8f2456e5b058a88730ec383d88634737849afdfb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 29, 2021
@openjdk
Copy link

openjdk bot commented Jun 29, 2021

@alexmenkov Pushed as commit 7a23c9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the jdwpListenAddress branch Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
3 participants