Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269188: [BACKOUT] Remove CodeCache::mark_for_evol_deoptimization() method #4563

Closed
wants to merge 1 commit into from

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Jun 23, 2021

This reverts commit 33c23a1.

Built locally linux-x64-debug and ran vmTestbase/nsk/jvmti tests.

See bug for details.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269188: [BACKOUT] Remove CodeCache::mark_for_evol_deoptimization() method

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4563/head:pull/4563
$ git checkout pull/4563

Update a local copy of the PR:
$ git checkout pull/4563
$ git pull https://git.openjdk.java.net/jdk pull/4563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4563

View PR using the GUI difftool:
$ git pr show -t 4563

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4563.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@coleenp The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 23, 2021

Webrevs

Loading

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks like an accurate backout.

Thanks,
David

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269188: [BACKOUT] Remove CodeCache::mark_for_evol_deoptimization() method

Reviewed-by: dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 2c29d79: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • 6237630: 8269120: Build failure with GCC 6.3.0 after JDK-8017163
  • a5e4307: 8269134: Remove sparsePRT.inline.hpp after JDK-8017163
  • 17daf32: 8269138: Move typeArrayOop.inline.hpp include to vectorSupport.cpp
  • 36d82b6: 8268858: Determine register pressure automatically by the number of available registers for allocation
  • ae3eedc: 8268727: Remove unused slowpath locking method in OptoRuntime
  • cd678a3: 8268368: Adopt cast notation for JavaThread conversions
  • b6cfca8: Merge
  • 35e4c27: 8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"
  • dc12cb7: 8267652: c2 loop unrolling by 8 results in reading memory past array
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/0c693e2f03b1adef0e946ebc32827ac09192f5f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 23, 2021
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Coleen,
This looks as correct backout to me too.
Thanks,
Serguei

Loading

@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Jun 23, 2021

Thanks David and Serguei. git had no problem with the revert.
/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

Going to push as commit 52d5d1b.
Since your change was applied there have been 19 commits pushed to the master branch:

  • f2e690e: 8268720: Unspecified checks on NameAndType constants should not be performed
  • 2c29d79: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • 6237630: 8269120: Build failure with GCC 6.3.0 after JDK-8017163
  • a5e4307: 8269134: Remove sparsePRT.inline.hpp after JDK-8017163
  • 17daf32: 8269138: Move typeArrayOop.inline.hpp include to vectorSupport.cpp
  • 36d82b6: 8268858: Determine register pressure automatically by the number of available registers for allocation
  • ae3eedc: 8268727: Remove unused slowpath locking method in OptoRuntime
  • cd678a3: 8268368: Adopt cast notation for JavaThread conversions
  • b6cfca8: Merge
  • 35e4c27: 8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/0c693e2f03b1adef0e946ebc32827ac09192f5f0...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@coleenp Pushed as commit 52d5d1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@coleenp coleenp deleted the deopt-all branch Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants