Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8269202: Support %p in jfr dump file name #4564

Closed
wants to merge 1 commit into from

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Jun 23, 2021

Currently, jfr supports 2 ways to name dump file.

  1. dump without a file name, it will generate a name automatically with pid.
  2. specify a file name explicitly, but without support for pid(%p)
    It will be helpful to support %p in file name.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4564/head:pull/4564
$ git checkout pull/4564

Update a local copy of the PR:
$ git checkout pull/4564
$ git pull https://git.openjdk.java.net/jdk pull/4564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4564

View PR using the GUI difftool:
$ git pr show -t 4564

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4564.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jun 23, 2021

Seems the build error is not related to this patch.

@openjdk openjdk bot added the rfr label Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Jun 23, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jun 23, 2021

/contributor add Jiahua Wu wujiahua3@huawei.com

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@Hamlin-Li Could not parse Jiahua Wu wujiahua3@huawei.com as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 23, 2021

Webrevs

@D-D-H
Copy link
Contributor

@D-D-H D-D-H commented Jun 23, 2021

Hi,

It seems duplicated with https://git.openjdk.java.net/jdk/pull/4550.

Denghui

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jun 23, 2021

duplicate with #4550

@Hamlin-Li Hamlin-Li closed this Jun 23, 2021
@Hamlin-Li Hamlin-Li deleted the jfr-pid branch Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr rfr
2 participants