JDK-8269202: Support %p in jfr dump file name #4564
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, jfr supports 2 ways to name dump file.
It will be helpful to support %p in file name.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4564/head:pull/4564$ git checkout pull/4564Update a local copy of the PR:
$ git checkout pull/4564$ git pull https://git.openjdk.java.net/jdk pull/4564/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4564View PR using the GUI difftool:
$ git pr show -t 4564Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4564.diff