Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC #4571

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 23, 2021

Hi all,

can I have reviews for this change that as the title suggest only changes the name of the G1AllowPreventiveGC option to G1UsePreventiveGC to better conform to other G1 options which all use Use.

Since this is a diagnostic flag, no further process is required.

Testing: tier1-5

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4571/head:pull/4571
$ git checkout pull/4571

Update a local copy of the PR:
$ git checkout pull/4571
$ git pull https://git.openjdk.java.net/jdk pull/4571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4571

View PR using the GUI difftool:
$ git pr show -t 4571

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4571.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 23, 2021

Webrevs

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jun 25, 2021

Currently asking for late enhancement request to jdk17, so closing this for now.

@tschatzl tschatzl closed this Jun 25, 2021
@tschatzl tschatzl reopened this Jun 29, 2021
Copy link
Member

@walulyai walulyai left a comment

lgtm!

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jun 29, 2021

Reopened on request by @JesperIRL .

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC

Reviewed-by: iwalulya, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 95 new commits pushed to the master branch:

  • a977157: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • ee1e202: 8268821: Split systemDictionaryShared.cpp
  • 03d54e6: Merge
  • 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes
  • 8d09596: 8269304: Regression ~5% in 2005 in b27
  • e4c5446: 8268236: The documentation of the String.regionMatches method contains error
  • e9b2c05: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/2e639dd34a4342de6e1b9470448d66ef89c4bd52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 29, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jun 29, 2021

Thanks @walulyai @kimbarrett for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

Going to push as commit 3f2c372.
Since your change was applied there have been 95 commits pushed to the master branch:

  • a977157: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • ee1e202: 8268821: Split systemDictionaryShared.cpp
  • 03d54e6: Merge
  • 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes
  • 8d09596: 8269304: Regression ~5% in 2005 in b27
  • e4c5446: 8268236: The documentation of the String.regionMatches method contains error
  • e9b2c05: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/2e639dd34a4342de6e1b9470448d66ef89c4bd52...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@tschatzl Pushed as commit 3f2c372.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8269126-use-preventive-gc branch Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants