8266407: remove jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES

[vicente-romero-oracle]

Enum constant: jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES was not removed when Sealed Classes were made final because the build was failing without it. Now that the feature is final we should be able to safely removed it. This is the intention of this patch.

TIA,
Vicente

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266407: remove jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4578/head:pull/4578
$ git checkout pull/4578

Update a local copy of the PR:
$ git checkout pull/4578
$ git pull https://git.openjdk.java.net/jdk pull/4578/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4578

View PR using the GUI difftool:
$ git pr show -t 4578

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4578.diff

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (081a66cd)

[jonathan-gibbons]

/label compiler

[openjdk]

@jonathan-gibbons
The compiler label was successfully added.

[lahodaj]

lgtm

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266407: remove jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 172 new commits pushed to the master branch:

• 4dfcf53: 8269935: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on windows
• 1578979: 8269917: Insert missing commas in copyrights in java.net
• 326b2e1: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation
• f485171: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE
• 16aa8cb: 8269697: JNI_GetPrimitiveArrayCritical() should not accept object array
• e47803a: 8266310: deadlock between System.loadLibrary and JNI FindClass loading another class
• 20eba35: 8269882: stack-use-after-scope in NewObjectA
• df0e11b: 8269672: C1: Remove unaligned move on all architectures
• 2926769: 8267956: C1 code cleanup
• acc3d99: 8268860: Windows-Aarch64 build is failing in GitHub actions
• ... and 162 more: https://git.openjdk.java.net/jdk/compare/7621fa37efb2739b953da1cda87dca4762b5bd0c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit 01c29d8.
Since your change was applied there have been 183 commits pushed to the master branch:

• 7a4f08a: Merge
• 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
• e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
• 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
• 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
• 2b20778: 8269568: JVM crashes when running VectorMask query tests
• 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
• df1364b: 8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372
• 6d8fc72: 8268883: C2: assert(false) failed: unscheduable graph
• 4ad8b04: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
• ... and 173 more: https://git.openjdk.java.net/jdk/compare/7621fa37efb2739b953da1cda87dca4762b5bd0c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 01c29d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.