8269293: ObjectMonitor thread id fields should be 64 bits.

[coleenp]

This is a trivial change to fix the type of _previous_version_tid and _notifier_tid in ObjectMonitor to be unint64_t.
Tested with tier1-3 and JFR tests on linux-x64-debug and windows-x64-debug. I don't have a 32 bit system to test this out on.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269293: ObjectMonitor thread id fields should be 64 bits.

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4584/head:pull/4584
$ git checkout pull/4584

Update a local copy of the PR:
$ git checkout pull/4584
$ git pull https://git.openjdk.java.net/jdk pull/4584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4584

View PR using the GUI difftool:
$ git pr show -t 4584

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4584.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[coleenp]

/label add hotspot-jfr

[openjdk]

@coleenp The label jfr is not a valid label. These labels are valid:

• serviceability
• hotspot
• sound
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• 2d
• swing
• hotspot-runtime
• jmx
• nio
• build
• beans
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr
• awt

[dholmes-ora]

Hi Coleen,

Is there any way we can use the JFR type definition "traceid" for this? If not then this looks fine.

Thanks,
David

[mlbridge]

Webrevs

• 00: Full (7950a627)

[dholmes-ora]

Note you can build a 32-bit VM and run it on a 64-bit system.

[shipilev]

Note you can build a 32-bit VM and run it on a 64-bit system.

...and GHA would run x86_32 tier1 for you. The patch is unlikely to cause trouble, but just look through GHA results.

[mlbridge]

Mailing list message from Coleen Phillimore on hotspot-runtime-dev:

On 6/24/21 9:18 AM, David Holmes wrote:

On Thu, 24 Jun 2021 13:05:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

This is a trivial change to fix the type of _previous_version_tid and _notifier_tid in ObjectMonitor to be unint64_t.
Tested with tier1-3 and JFR tests on linux-x64-debug and windows-x64-debug. I don't have a 32 bit system to test this out on.
Hi Coleen,

Is there any way we can use the JFR type definition "traceid" for this? If not then this looks fine.

Thanks for the quick review.? It's pretty awkward to include
jfr/support/jfrThreadId.hpp in objectMonitor.hpp (JFR is included
conditionally), so would have to include these fields conditionally, and
add #if INCLUDE_JFR in lots of places.? It's not nice.

Thanks,
Coleen

[mlbridge]

Mailing list message from Coleen Phillimore on hotspot-runtime-dev:

On 6/24/21 9:18 AM, David Holmes wrote:

On Thu, 24 Jun 2021 13:05:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

This is a trivial change to fix the type of _previous_version_tid and _notifier_tid in ObjectMonitor to be unint64_t.
Tested with tier1-3 and JFR tests on linux-x64-debug and windows-x64-debug. I don't have a 32 bit system to test this out on.
Hi Coleen,

Is there any way we can use the JFR type definition "traceid" for this? If not then this looks fine.

Thanks for the quick review.? It's pretty awkward to include
jfr/support/jfrThreadId.hpp in objectMonitor.hpp (JFR is included
conditionally), so would have to include these fields conditionally, and
add #if INCLUDE_JFR in lots of places.? It's not nice.

Thanks,
Coleen

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269293: ObjectMonitor thread id fields should be 64 bits.

Reviewed-by: mgronlun, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 7c31903: 8267075: jcmd VM.cds should print directory of the output files

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

Thumbs up.

[coleenp]

Thanks David, Markus and Dan. The github actions built linux-x86 so that's ok.
/integrate

[openjdk]

Going to push as commit 42968db.
Since your change was applied there have been 3 commits pushed to the master branch:

• 2fd7943: 8256425: Obsolete Biased Locking in JDK 18
• 595446b: 8269087: CheckSegmentedCodeCache test fails in an emulated-client VM
• 7c31903: 8267075: jcmd VM.cds should print directory of the output files

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 42968db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.