Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269294: Verify_before/after_young_collection should execute all verification #4586

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 24, 2021

Hi all,

can I have reviews for this tiny change that moves all verification from do_collection_pause_at_safepoint_helper() to verify_before/after_young_collection?

I actually removed one call to _hrm.verify_optional() because it is already called in _verifier->verify_region_sets_optional although they are not completely equivalent as one call is DEBUG_ONLY and the other NOT_PRODUCT, but nobody is probably using the optimized build anyway. I can re-add the missing call if required.

Testing: tier1

Thanks,
Thomas

P.S: this is based on PR#4539, so it would be nice if it could be reviewed before this.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269294: Verify_before/after_young_collection should execute all verification

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4586/head:pull/4586
$ git checkout pull/4586

Update a local copy of the PR:
$ git checkout pull/4586
$ git pull https://git.openjdk.java.net/jdk pull/4586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4586

View PR using the GUI difftool:
$ git pr show -t 4586

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4586.diff

@tschatzl tschatzl marked this pull request as ready for review Jun 24, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/4539 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2021

Webrevs

Copy link
Member

@walulyai walulyai left a comment

lgtm!

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/4539 to master Jul 7, 2021
@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented Jul 7, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8269022-evac-failure-string-in-gc-info-message
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@tschatzl this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8269294-merge-verify-stages
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict label Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269294: Verify_before/after_young_collection should execute all verification

Reviewed-by: iwalulya, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready and removed merge-conflict labels Jul 7, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jul 7, 2021

Thanks @kimbarrett @walulyai for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

Going to push as commit 248aa50.

@openjdk openjdk bot closed this Jul 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@tschatzl Pushed as commit 248aa50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8269294-merge-verify-stages branch Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants