Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269295: Verification time before/after young collection only covers parts of the verification #4587

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jun 24, 2021

Hi all,

can I have reviews for this change that makes "Verify Before/After GC" contain all young collection time instead only a (large) part.

This change also removed some unnecessary and unused return values. They can certainly be re-added if necessary.

Testing: tier1

Thanks,
Thomas

Note: this depends on PR4586.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269295: Verification time before/after young collection only covers parts of the verification

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4587/head:pull/4587
$ git checkout pull/4587

Update a local copy of the PR:
$ git checkout pull/4587
$ git pull https://git.openjdk.java.net/jdk pull/4587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4587

View PR using the GUI difftool:
$ git pr show -t 4587

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4587.diff

JornVernee and others added 3 commits Jun 22, 2021
…32: String conversion seems broken

Reviewed-by: mcimadamore
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 33c23a1 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nils Eliasson and others added 2 commits Jun 22, 2021
Reviewed-by: iwalulya, tschatzl
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 0c693e2 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andy Herrick and others added 2 commits Jun 22, 2021
…ailed "AssertionError: Failed: Check icon"

Reviewed-by: asemenyuk
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on b6cfca8 Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dean-long and others added 2 commits Jun 23, 2021
… under compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/

Reviewed-by: ngasson, dnsimon, kvn
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on cd678a3 Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on ae3eedc Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…vailable registers for allocation

Reviewed-by: kvn, dlong
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 36d82b6 Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 17daf32 Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on a5e4307 Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: iwalulya, tschatzl, kbarrett
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 6237630 Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 2c29d79 Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoeLin
Copy link
Member

@GoeLin GoeLin commented on 2c29d79 Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

openjdk[bot]
Copy link

@openjdk openjdk bot commented on 2c29d79 Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-2c29d790 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2c29d790 from the openjdk/jdk repository.

The commit being backported was authored by miao zheng on 23 Jun 2021 and was reviewed by David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-2c29d790:GoeLin-backport-2c29d790
$ git checkout GoeLin-backport-2c29d790
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-2c29d790

pliden and others added 2 commits Jun 23, 2021
Reviewed-by: eosterlund, stefank, kbarrett, tschatzl
8268896: Parenthesized pattern is not guarded by source level check

Reviewed-by: vromero
Jatin Bhateja and others added 3 commits Jul 8, 2021
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on bca570c Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 4f322a9 Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 6f171b9 Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 5832882 Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian Burkhalter and others added 4 commits Jul 8, 2021
…consistent with InputStream when at EOF

Reviewed-by: naoto, lancea, joehw
Reviewed-by: hannesw
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on dfd6b2b Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8270018: Add scoped object for g1 young gc JFR notification

Reviewed-by: ayang, iwalulya, kbarrett
openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on c93204c Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 676f1d7 Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjdk-notifier[bot]
Copy link

@openjdk-notifier openjdk-notifier bot commented on 3d193ad Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tschatzl tschatzl restored the submit/8269295-verify-time-only-covers-parts branch Jul 9, 2021
@tschatzl tschatzl reopened this Jul 9, 2021
@tschatzl tschatzl closed this Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269295: Verification time before/after young collection only covers parts of the verification

Reviewed-by: lkorinth, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5a74291: 8266565: Spec of ForwardingJavaFileManager/ForwardingFileObject/ForwardingJavaFileObject methods should mention delegation instead of being copied

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 9, 2021
@tschatzl tschatzl deleted the submit/8269295-verify-time-only-covers-parts branch Jul 13, 2021
VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented on a30141d Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk15u-dev

openjdk[bot]
Copy link

@openjdk openjdk bot commented on a30141d Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirKempik @VladimirKempik the backport was successfully created on the branch VladimirKempik-backport-a30141d6 in my personal fork of openjdk/jdk15u-dev. To create a pull request with this backport targeting openjdk/jdk15u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit a30141d6 from the openjdk/jdk repository.

The commit being backported was authored by Jie Fu on 24 Jun 2021 and was reviewed by Vladimir Kozlov and Nils Eliasson.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk15u-dev:

$ git fetch https://github.com/openjdk-bots/jdk15u-dev VladimirKempik-backport-a30141d6:VladimirKempik-backport-a30141d6
$ git checkout VladimirKempik-backport-a30141d6
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk15u-dev VladimirKempik-backport-a30141d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc ready rfr