8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433

[alexmenkov]

Please review this trivial fix in the cycle condition.

The cycle should run until connection is established (connection.isConnected() returns true) or error occurred (error != null)
This wrong condition causes test error if ListenerThread.getConnection() reaches "synchronized (this)" section earlier than ListenerThread.run()

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433

Reviewers

• Kevin Walls (@kevinjwalls - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4593/head:pull/4593
$ git checkout pull/4593

Update a local copy of the PR:
$ git checkout pull/4593
$ git pull https://git.openjdk.java.net/jdk pull/4593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4593

View PR using the GUI difftool:
$ git pr show -t 4593

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4593.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5c733d78)

[dholmes-ora]

Good catch!

[dcubed-ojdk]

@alexmenkov - would you mind withdrawing this PR and creating a new PR against JDK17?
We're seeing these test failures in the JDK17 CI also. I've bumped the priority of the bug
from P4 -> P3 since we're seeing Tier3 test failures.

[alexmenkov]

@alexmenkov - would you mind withdrawing this PR and creating a new PR against JDK17?
We're seeing these test failures in the JDK17 CI also. I've bumped the priority of the bug
from P4 -> P3 since we're seeing Tier3 test failures.

Makes sense.
Will do