8269417: Minor clarification on NonblockingQueue utility

[caoman]

Hi,

Could you review this change mainly based on the comments in #4379?
I also added an assertion to ensure and better understand why the Atomic::store() in append() is correct.

Stress tested with fastdebug build with:
$ make test TEST="gtest:NonblockingQueueTestBasics gtest:NonblockingQueueTest" GTEST="REPEAT=-1"

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269417: Minor clarification on NonblockingQueue utility

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to e789072
• Ivan Walulya (@walulyai - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4600/head:pull/4600
$ git checkout pull/4600

Update a local copy of the PR:
$ git checkout pull/4600
$ git pull https://git.openjdk.java.net/jdk pull/4600/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4600

View PR using the GUI difftool:
$ git pr show -t 4600

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4600.diff

[bridgekeeper]

👋 Welcome back manc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@caoman The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (32d68b7b)
• 01: Full - Incremental (e7890729)
• 00: Full (b4150ec9)

[kimbarrett]

Looks good. Just one suggestion in commentary.

[openjdk]

@caoman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269417: Minor clarification on NonblockingQueue utility

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• a977157: 8261579: AArch64: Support for weaker memory ordering in Atomic
• ee1e202: 8268821: Split systemDictionaryShared.cpp
• 03d54e6: Merge
• 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
• 09bb846: 8267952: async logging supports to dynamically change tags and decorators
• 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
• efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes
• 8d09596: 8269304: Regression ~5% in 2005 in b27
• e4c5446: 8268236: The documentation of the String.regionMatches method contains error

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good.

[walulyai]

lgtm!

[caoman]

/integrate

[openjdk]

Going to push as commit bb42d75.
Since your change was applied there have been 11 commits pushed to the master branch:

• e238cbd: 8269530: runtime/ParallelLoad/ParallelSuperTest.java timeout
• 3f2c372: 8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC
• a977157: 8261579: AArch64: Support for weaker memory ordering in Atomic
• ee1e202: 8268821: Split systemDictionaryShared.cpp
• 03d54e6: Merge
• 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
• 09bb846: 8267952: async logging supports to dynamically change tags and decorators
• 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
• efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes
• 8d09596: 8269304: Regression ~5% in 2005 in b27
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/e9b2c058a4ed5de29b991360f78fc1c5263c9268...master

Your commit was automatically rebased without conflicts.

[openjdk]

@caoman Pushed as commit bb42d75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.