8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient

[shipilev]

After JDK-8259954, some mxbeans tests wait in the effectively infinite loop for the notifications to arrive. If notifications are broken, it would wait forever, and test would timeout. We need to make such failure mode more straightforward.

Additional testing:

• Linux x86_64 fastdebug gc/shenandoah/mxbeans
• Linux x86_64 fastdebug gc/shenandoah/mxbeans, -Xcomp

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient

Reviewers

• Roman Kennke (@rkennke - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4611/head:pull/4611
$ git checkout pull/4611

Update a local copy of the PR:
$ git checkout pull/4611
$ git pull https://git.openjdk.java.net/jdk pull/4611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4611

View PR using the GUI difftool:
$ git pr show -t 4611

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4611.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (612957fd)
• 03: Full - Incremental (a9eeaeff)
• 02: Full - Incremental (029ed18f)
• 01: Full - Incremental (a00be3e6)
• 00: Full (77278d43)

[rkennke]

Looks good. Thanks!

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
• 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
• b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
• ee526a2: Merge
• 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
• d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
• 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
• b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
• 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
• 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127
• ... and 9 more: https://git.openjdk.java.net/jdk/compare/a97715755d01b88ad9e4cf32f10ca5a3f2fda898...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

I have rewritten the tests so that they pass slowdebug + -Xcomp. Also they are looking at the actual timeout configuration for the test, so users can control how long to wait with usual timeoutFactor.

[shipilev]

Rewrote the PauseNotification test to capture notification counts, not pause times. Mostly because the 1ms resolution is not enough to guarantee non-zero sum of pauses.

[shipilev]

@rkennke, @zhengyu123, need another review here, I think.

[shipilev]

/integrate

[openjdk]

Going to push as commit 23d2996.
Since your change was applied there have been 21 commits pushed to the master branch:

• a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
• a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
• ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
• 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
• b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
• ee526a2: Merge
• 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
• d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
• 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
• b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/a97715755d01b88ad9e4cf32f10ca5a3f2fda898...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 23d2996.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.