New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient #4611
Conversation
|
Webrevs
|
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
I have rewritten the tests so that they pass |
a9eeaef
to
612957f
Compare
Rewrote the |
@rkennke, @zhengyu123, need another review here, I think. |
/integrate |
Going to push as commit 23d2996.
Your commit was automatically rebased without conflicts. |
After JDK-8259954, some mxbeans tests wait in the effectively infinite loop for the notifications to arrive. If notifications are broken, it would wait forever, and test would timeout. We need to make such failure mode more straightforward.
Additional testing:
gc/shenandoah/mxbeans
gc/shenandoah/mxbeans
,-Xcomp
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4611/head:pull/4611
$ git checkout pull/4611
Update a local copy of the PR:
$ git checkout pull/4611
$ git pull https://git.openjdk.java.net/jdk pull/4611/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4611
View PR using the GUI difftool:
$ git pr show -t 4611
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4611.diff