Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269516: AArch64: Assembler cleanups #4612

Closed
wants to merge 4 commits into from

Conversation

@theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Jun 28, 2021

The core of the AArch64 assembler is unnecessarily complex, with multiple indirections from class Assembler. We can get rid of them, which makes libjvm.so faster and smaller. Also, there are some dubious casts from FloatRegister to Register which should use a proper conversion function.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4612/head:pull/4612
$ git checkout pull/4612

Update a local copy of the PR:
$ git checkout pull/4612
$ git pull https://git.openjdk.java.net/jdk pull/4612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4612

View PR using the GUI difftool:
$ git pr show -t 4612

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4612.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 28, 2021

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

Copy link
Contributor Author

@theRealAph theRealAph left a comment

Tested Linux/AArch64 tier1.

Loading

@openjdk openjdk bot added the rfr label Jun 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@theRealAph The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 28, 2021

Webrevs

Loading

Copy link
Member

@nick-arm nick-arm left a comment

Looks OK to me

Loading

adinn
adinn approved these changes Jun 30, 2021
Copy link
Contributor

@adinn adinn left a comment

All looks good

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269516: AArch64: Assembler cleanups

Reviewed-by: ngasson, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • ee526a2: Merge
  • 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
  • d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
  • 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
  • b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
  • 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
  • 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/4d2412ef3e1068063acc954a00b4db0fa4b5affb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 30, 2021
@theRealAph
Copy link
Contributor Author

@theRealAph theRealAph commented Jun 30, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

Going to push as commit 1810b1c.
Since your change was applied there have been 36 commits pushed to the master branch:

  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • ee526a2: Merge
  • 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
  • d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/4d2412ef3e1068063acc954a00b4db0fa4b5affb...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@theRealAph Pushed as commit 1810b1c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants