Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K #4615

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Jun 28, 2021

More refactoring to limit the scope of @SuppressWarnings annotations.

Sometimes I introduce new methods. Please feel free to suggest method names you like to use.

Note: this is copied from openjdk/jdk17#152.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4615/head:pull/4615
$ git checkout pull/4615

Update a local copy of the PR:
$ git checkout pull/4615
$ git pull https://git.openjdk.java.net/jdk pull/4615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4615

View PR using the GUI difftool:
$ git pr show -t 4615

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4615.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 28, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 28, 2021
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jun 28, 2021

/reviewer credit @naotoj

@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@wangweij The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security serviceability core-libs net i18n labels Jun 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@wangweij
Reviewer naoto successfully credited.

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jun 28, 2021

/reviewer credit @LanceAndersen

@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@wangweij
Reviewer lancea successfully credited.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 28, 2021

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

The revisions you made as part of the push to JDK 18 look fine Max.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 225 new commits pushed to the master branch:

  • d0d26f5: 8269433: Remove effectively unused ReferenceProcessor::_enqueuing_is_done
  • 29bc381: 8268902: Testing for threadObj != NULL is unnecessary in suspend handshake
  • 87ff277: 8269222: Incorrect number of workers reported for reference processing
  • 4d2412e: 8269122: The use of "extern const" for Register definitions generates poor code
  • f45be15: 8269003: Update the java manpage for JDK 18
  • a29953d: Merge
  • d9cb068: 8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash
  • 6eb734a: 8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class
  • 3d0d27c: 8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces
  • 824a516: 8269260: Add AVX512 and other SSE + AVX combinations testing for tests which generate vector instructions
  • ... and 215 more: https://git.openjdk.java.net/jdk/compare/e11f70aeb6a38ad05f7035461a6094320b03fc40...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 28, 2021
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jun 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

Going to push as commit e9b2c05.
Since your change was applied there have been 225 commits pushed to the master branch:

  • d0d26f5: 8269433: Remove effectively unused ReferenceProcessor::_enqueuing_is_done
  • 29bc381: 8268902: Testing for threadObj != NULL is unnecessary in suspend handshake
  • 87ff277: 8269222: Incorrect number of workers reported for reference processing
  • 4d2412e: 8269122: The use of "extern const" for Register definitions generates poor code
  • f45be15: 8269003: Update the java manpage for JDK 18
  • a29953d: Merge
  • d9cb068: 8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash
  • 6eb734a: 8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class
  • 3d0d27c: 8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces
  • 824a516: 8269260: Add AVX512 and other SSE + AVX combinations testing for tests which generate vector instructions
  • ... and 215 more: https://git.openjdk.java.net/jdk/compare/e11f70aeb6a38ad05f7035461a6094320b03fc40...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@wangweij Pushed as commit e9b2c05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8269409 branch Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs i18n integrated net security serviceability
2 participants