-
Notifications
You must be signed in to change notification settings - Fork 6k
8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
/reviewer credit @naotoj |
@wangweij The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@wangweij |
/reviewer credit @LanceAndersen |
@wangweij |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The revisions you made as part of the push to JDK 18 look fine Max.
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 225 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e9b2c05.
Your commit was automatically rebased without conflicts. |
More refactoring to limit the scope of
@SuppressWarnings
annotations.Sometimes I introduce new methods. Please feel free to suggest method names you like to use.
Note: this is copied from openjdk/jdk17#152.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4615/head:pull/4615
$ git checkout pull/4615
Update a local copy of the PR:
$ git checkout pull/4615
$ git pull https://git.openjdk.java.net/jdk pull/4615/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4615
View PR using the GUI difftool:
$ git pr show -t 4615
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4615.diff