Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8199594: Add doc describing how (?x) ignores spaces in character classes #4618

Closed
wants to merge 3 commits into from
Closed

8199594: Add doc describing how (?x) ignores spaces in character classes #4618

wants to merge 3 commits into from

Conversation

igraves
Copy link
Member

@igraves igraves commented Jun 28, 2021 •
edited by openjdk bot

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8199594: Add doc describing how (?x) ignores spaces in character classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4618/head:pull/4618
$ git checkout pull/4618

Update a local copy of the PR:
$ git checkout pull/4618
$ git pull https://git.openjdk.java.net/jdk pull/4618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4618

View PR using the GUI difftool:
$ git pr show -t 4618

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4618.diff

@igraves
Copy link
Member Author

igraves commented Jun 28, 2021

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2021

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jun 28, 2021
@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@igraves this pull request will not be integrated until the CSR request JDK-8265487 for issue JDK-8199594 has been approved.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2021
@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@igraves The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2021 •
edited

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jul 6, 2021
@openjdk
Copy link

openjdk bot commented Jul 21, 2021 •
edited

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8199594: Add doc describing how (?x) ignores spaces in character classes

Reviewed-by: darcy, naoto, iris, lancea, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 351 new commits pushed to the master branch:

  • 4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • ec71e2d: 8271221: [BACKOUT] JDK-8271063 Print injected fields for InstanceKlass
  • f4b3ee5: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
  • 45abbee: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails
  • c9251db: 8271209: Fix doc comment typos in JavadocTokenizer
  • 96247ae: 8270187: G1: Remove ConcGCThreads constraint
  • 9b27df6: 8271063: Print injected fields for InstanceKlass
  • 0cc4bb7: 8270870: Simplify G1ServiceThread
  • 8c8e3a0: 8271163: G1 uses wrong degree of MT processing since JDK-8270169
  • 8a789b7: 8263840: PeriodicTask should declare its destructor virtual
  • ... and 341 more: https://git.openjdk.java.net/jdk/compare/e9b2c058a4ed5de29b991360f78fc1c5263c9268...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2021
irisclark
irisclark approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes match corresponding, approved CSR.

LanceAndersen
LanceAndersen reviewed Jul 21, 2021
View reviewed changes
src/java.base/share/classes/java/util/regex/Pattern.java Outdated
@@ -755,6 +755,14 @@
* within a group; in the latter case, flags are restored at the end of the
* group just as in Perl. </p></li>
*
* <li><p> In Perl, <i>free-spacing mode</i> (which is called <i>comments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one suggestion is to perhaps re-phrase the opening of the paragraph as the preceding paragraph also starts with "In-Perl".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Re-worded to "Free-spacing mode in Perl (called comments..."

@igraves
Copy link
Member Author

igraves commented Jul 23, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

Going to push as commit a1c0a6a.
Since your change was applied there have been 351 commits pushed to the master branch:

  • 4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • ec71e2d: 8271221: [BACKOUT] JDK-8271063 Print injected fields for InstanceKlass
  • f4b3ee5: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
  • 45abbee: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails
  • c9251db: 8271209: Fix doc comment typos in JavadocTokenizer
  • 96247ae: 8270187: G1: Remove ConcGCThreads constraint
  • 9b27df6: 8271063: Print injected fields for InstanceKlass
  • 0cc4bb7: 8270870: Simplify G1ServiceThread
  • 8c8e3a0: 8271163: G1 uses wrong degree of MT processing since JDK-8270169
  • 8a789b7: 8263840: PeriodicTask should declare its destructor virtual
  • ... and 341 more: https://git.openjdk.java.net/jdk/compare/e9b2c058a4ed5de29b991360f78fc1c5263c9268...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2021
@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@igraves Pushed as commit a1c0a6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelrappo pavelrappo pavelrappo left review comments

@naotoj naotoj naotoj approved these changes

@LanceAndersen LanceAndersen LanceAndersen approved these changes

@jddarcy jddarcy jddarcy approved these changes

@irisclark irisclark irisclark approved these changes

@bplb bplb bplb approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
7 participants
@igraves @naotoj @LanceAndersen @jddarcy @pavelrappo @irisclark @bplb