Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268298: jdk/jfr/api/consumer/log/TestVerbosity.java fails: unexpected log message #4631

Closed
wants to merge 1 commit into from

Conversation

D-D-H
Copy link
Contributor

@D-D-H D-D-H commented Jun 30, 2021

Hi,

Could I have a review of this small test fix that disables jdk.ExecutionSample when run TestVerbosity with arg debug to prevent unexpected method1.

Regards,
Denghui


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268298: jdk/jfr/api/consumer/log/TestVerbosity.java fails: unexpected log message

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4631/head:pull/4631
$ git checkout pull/4631

Update a local copy of the PR:
$ git checkout pull/4631
$ git pull https://git.openjdk.java.net/jdk pull/4631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4631

View PR using the GUI difftool:
$ git pr show -t 4631

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4631.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 30, 2021

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@D-D-H
Copy link
Contributor Author

@D-D-H D-D-H commented Jun 30, 2021

/label add hotspot-jfr

@openjdk openjdk bot added rfr hotspot-jfr labels Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@D-D-H
The hotspot-jfr label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 30, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@D-D-H This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268298: jdk/jfr/api/consumer/log/TestVerbosity.java fails: unexpected log message

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 1810b1c: 8269516: AArch64: Assembler cleanups
  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 30, 2021
@D-D-H
Copy link
Contributor Author

@D-D-H D-D-H commented Jun 30, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@D-D-H
Your change (at version 3899c49) is now ready to be sponsored by a Committer.

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Jul 1, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

Going to push as commit 06d2620.
Since your change was applied there have been 28 commits pushed to the master branch:

  • d89e630: 8266746: C1: Replace UnsafeGetRaw with UnsafeGet when setting up OSR entry block
  • 4660f72: 8268870: Remove dead code in metaspaceShared
  • 9def3b0: Merge
  • 9ac63a6: 8262841: Clarify the behavior of PhantomReference::refersTo
  • aba6c55: 8269703: ProblemList vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java on Windows-X64 with -Xcomp
  • 3e02224: 8269513: Clarify the spec wrt useOldISOCodes system property
  • 0dc65d3: 8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet
  • 3826012: 8268557: Module page uses unstyled table class
  • 2b17e95: 8269691: ProblemList sun/management/jdp/JdpDefaultsTest.java on Linux-aarch64
  • 1da5d4b: 8269486: CallerAccessTest fails for non server variant
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/b969136b9fcf5f977ebe466f5f9de5c520413e84...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@kelthuzadx @D-D-H Pushed as commit 06d2620.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr integrated
3 participants