Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8133873: Simplify {Register,Unregister}NMethodOopClosure #4632

Closed
wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 30, 2021

Simple change of excluding compressed oops in nmethod closures.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8133873: Simplify {Register,Unregister}NMethodOopClosure

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4632/head:pull/4632
$ git checkout pull/4632

Update a local copy of the PR:
$ git checkout pull/4632
$ git pull https://git.openjdk.java.net/jdk pull/4632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4632

View PR using the GUI difftool:
$ git pr show -t 4632

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4632.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 30, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jun 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 30, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8133873: Simplify {Register,Unregister}NMethodOopClosure

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 85262c7: 8268637: Update --release 17 symbol information for JDK 17 build 28
  • 5c08344: 8269678: Remove unimplemented and unused os::bind_to_processor()
  • 83bce94: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • 1810b1c: 8269516: AArch64: Assembler cleanups
  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/87ff27786b7310840aab00c391e2a7fa19a3c328...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 30, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jul 1, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

Going to push as commit 54a9c3e.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 06d2620: 8268298: jdk/jfr/api/consumer/log/TestVerbosity.java fails: unexpected log message
  • d89e630: 8266746: C1: Replace UnsafeGetRaw with UnsafeGet when setting up OSR entry block
  • 4660f72: 8268870: Remove dead code in metaspaceShared
  • 9def3b0: Merge
  • 9ac63a6: 8262841: Clarify the behavior of PhantomReference::refersTo
  • aba6c55: 8269703: ProblemList vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java on Windows-X64 with -Xcomp
  • 3e02224: 8269513: Clarify the spec wrt useOldISOCodes system property
  • 0dc65d3: 8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet
  • 3826012: 8268557: Module page uses unstyled table class
  • 2b17e95: 8269691: ProblemList sun/management/jdp/JdpDefaultsTest.java on Linux-aarch64
  • ... and 48 more: https://git.openjdk.java.net/jdk/compare/87ff27786b7310840aab00c391e2a7fa19a3c328...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@albertnetymk Pushed as commit 54a9c3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the reg_nmethod branch Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants