Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet #4635

Closed

Conversation

@neliasso
Copy link
Contributor

@neliasso neliasso commented Jun 30, 2021

Hi,

This is a small fix of a test bug.

RandomCommandsTest.java can generate command file only containing a quiet command but with an invalid method descriptor. But Quiet commands are handled separately in the parser because they are just a global option. Any method descriptor will be discarded without validation.

This fix just makes sure we don't generate bad descriptor for quiet. That means we won't expect them to fail on the descriptor.

Please review,
Best regards,
Nils Eliasson


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4635/head:pull/4635
$ git checkout pull/4635

Update a local copy of the PR:
$ git checkout pull/4635
$ git pull https://git.openjdk.java.net/jdk pull/4635/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4635

View PR using the GUI difftool:
$ git pr show -t 4635

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4635.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 30, 2021

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@neliasso The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@neliasso neliasso marked this pull request as ready for review Jun 30, 2021
@openjdk openjdk bot added the rfr label Jun 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 30, 2021

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 83bce94: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • 1810b1c: 8269516: AArch64: Assembler cleanups
  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • ee526a2: Merge
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/f45be1519e84dd0562a841ceb23bcec4dec1437f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 30, 2021
@neliasso
Copy link
Contributor Author

@neliasso neliasso commented Jun 30, 2021

Moving to JDK 17.

Loading

@neliasso neliasso closed this Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants