Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269678: Remove unimplemented and unused os::bind_to_processor() #4640

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jun 30, 2021

Please review this trivial patch that removes unimplemented and unused method, appears to be a leftover from Solaris port.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269678: Remove unimplemented and unused os::bind_to_processor()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4640/head:pull/4640
$ git checkout pull/4640

Update a local copy of the PR:
$ git checkout pull/4640
$ git pull https://git.openjdk.java.net/jdk pull/4640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4640

View PR using the GUI difftool:
$ git pr show -t 4640

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4640.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@zhengyu123 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 30, 2021
@zhengyu123 zhengyu123 marked this pull request as ready for review June 30, 2021 17:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 30, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269678: Remove unimplemented and unused os::bind_to_processor()

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 83bce94: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • 1810b1c: 8269516: AArch64: Assembler cleanups
  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • ee526a2: Merge
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/a97715755d01b88ad9e4cf32f10ca5a3f2fda898...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2021
@zhengyu123
Copy link
Contributor Author

@dcubed-ojdk Thanks!

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

Going to push as commit 5c08344.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 83bce94: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • 1810b1c: 8269516: AArch64: Assembler cleanups
  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • ee526a2: Merge
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/a97715755d01b88ad9e4cf32f10ca5a3f2fda898...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@zhengyu123 Pushed as commit 5c08344.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants