Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8269110: ZGC: Remove dead code in zBarrier #4649

Closed

Conversation

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Jul 1, 2021

this is a trivial cleanup to remove some dead code in zBarrier.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4649/head:pull/4649
$ git checkout pull/4649

Update a local copy of the PR:
$ git checkout pull/4649
$ git pull https://git.openjdk.java.net/jdk pull/4649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4649

View PR using the GUI difftool:
$ git pr show -t 4649

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4649.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 1, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jul 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 1, 2021

Webrevs

Loading

pliden
pliden approved these changes Jul 1, 2021
Copy link
Contributor

@pliden pliden left a comment

Change looks good. However, note that the title of a PR shouldn't start with JDK-. I'm a bit surprised that the Skara bot hasn't complained about and/or auto-corrected that.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269110: ZGC: Remove dead code in zBarrier

Reviewed-by: pliden

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 144 new commits pushed to the master branch:

  • 82bfc5d: 8268960: com/sun/net/httpserver/Headers.java: Ensure mutators normalize keys and disallow null for keys and values
  • 18f356a: 8267307: Introduce new client property for XAWT: xawt.mwm_decor_title
  • 54a9c3e: 8133873: Simplify {Register,Unregister}NMethodOopClosure
  • 06d2620: 8268298: jdk/jfr/api/consumer/log/TestVerbosity.java fails: unexpected log message
  • d89e630: 8266746: C1: Replace UnsafeGetRaw with UnsafeGet when setting up OSR entry block
  • 4660f72: 8268870: Remove dead code in metaspaceShared
  • 9def3b0: Merge
  • 9ac63a6: 8262841: Clarify the behavior of PhantomReference::refersTo
  • aba6c55: 8269703: ProblemList vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java on Windows-X64 with -Xcomp
  • 3e02224: 8269513: Clarify the spec wrt useOldISOCodes system property
  • ... and 134 more: https://git.openjdk.java.net/jdk/compare/2e639dd34a4342de6e1b9470448d66ef89c4bd52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 1, 2021
@pliden
Copy link
Contributor

@pliden pliden commented Jul 1, 2021

Ok, so it looks like the bot reformated the commit message correctly anyway.

Loading

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jul 2, 2021

Thanks @pliden for review and comment, I'll use the correct PR title in the future.

Loading

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jul 2, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

Going to push as commit 589f084.
Since your change was applied there have been 158 commits pushed to the master branch:

  • b0e1867: Merge
  • a4d2a9a: 8269745: [JVMCI] restore original qualified exports to Graal
  • e377397: 8268566: java/foreign/TestResourceScope.java timed out
  • 6c76e77: 8260684: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java timed out
  • 4bbf11d: 8269580: assert(is_valid()) failed: invalid register (-1)
  • 54dd510: 8269704: Typo in j.t.Normalizer.normalize()
  • a8385fe: 8269354: javac crashes when processing parenthesized pattern in instanceof
  • c16d1fc: 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998
  • ad27d9b: 8269088: C2 fails with assert(!n->is_Store() && !n->is_LoadStore()) failed: no node with a side effect
  • c67a7b0: 8269230: C2: main loop in micro benchmark never executed
  • ... and 148 more: https://git.openjdk.java.net/jdk/compare/2e639dd34a4342de6e1b9470448d66ef89c4bd52...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@Hamlin-Li Pushed as commit 589f084.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@Hamlin-Li Hamlin-Li deleted the remove-dead-code-zBarrier branch Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants