Skip to content

Conversation

@y1yang0
Copy link
Member

@y1yang0 y1yang0 commented Jul 2, 2021

This is a follow up PR for #3917, it's rather a cleanup, no functional change.

As @TheRealMDoerr said

The "unaligned" parameter is unused on all platforms, now. Note that PPC64 and s390 support unaligned accesses, too. I believe it was used by SPARC which has been removed.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269672: C1: Remove unaligned move on all architectures

Reviewers

Contributors

  • Martin Doerr <mdoerr@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4662/head:pull/4662
$ git checkout pull/4662

Update a local copy of the PR:
$ git checkout pull/4662
$ git pull https://git.openjdk.java.net/jdk pull/4662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4662

View PR using the GUI difftool:
$ git pr show -t 4662

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4662.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 2, 2021
@openjdk
Copy link

openjdk bot commented Jul 2, 2021

@kelthuzadx The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 2, 2021
@y1yang0
Copy link
Member Author

y1yang0 commented Jul 2, 2021

/label remove Shenandoah

/label remove hotspot

/label add hotspot-compiler

@openjdk
Copy link

openjdk bot commented Jul 2, 2021

@kelthuzadx The label Shenandoah is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Jul 2, 2021
@openjdk
Copy link

openjdk bot commented Jul 2, 2021

@kelthuzadx
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 2, 2021
@openjdk
Copy link

openjdk bot commented Jul 2, 2021

@kelthuzadx
The hotspot-compiler label was successfully added.

@y1yang0
Copy link
Member Author

y1yang0 commented Jul 2, 2021

/label remove shenandoah

@mlbridge
Copy link

mlbridge bot commented Jul 2, 2021

Webrevs

@openjdk openjdk bot removed the shenandoah shenandoah-dev@openjdk.org label Jul 2, 2021
@openjdk
Copy link

openjdk bot commented Jul 2, 2021

@kelthuzadx
The shenandoah label was successfully removed.

@y1yang0
Copy link
Member Author

y1yang0 commented Jul 2, 2021

/contributor add mdoerr

@openjdk
Copy link

openjdk bot commented Jul 2, 2021

@kelthuzadx
Contributor Martin Doerr <mdoerr@openjdk.org> successfully added.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 5, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269672: C1: Remove unaligned move on all architectures

Co-authored-by: Martin Doerr <mdoerr@openjdk.org>
Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2021
@y1yang0
Copy link
Member Author

y1yang0 commented Jul 6, 2021

Thank you, Tobias! I'd like to treat this non-functional change as "trivial" change.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 6, 2021

Going to push as commit df0e11b.
Since your change was applied there have been 48 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 6, 2021
@openjdk
Copy link

openjdk bot commented Jul 6, 2021

@kelthuzadx Pushed as commit df0e11b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@y1yang0 y1yang0 deleted the remove_unaligned branch July 6, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants