Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269672: C1: Remove unaligned move on all architectures #4662

Closed
wants to merge 1 commit into from

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Jul 2, 2021

This is a follow up PR for #3917, it's rather a cleanup, no functional change.

As @TheRealMDoerr said

The "unaligned" parameter is unused on all platforms, now. Note that PPC64 and s390 support unaligned accesses, too. I believe it was used by SPARC which has been removed.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269672: C1: Remove unaligned move on all architectures

Reviewers

Contributors

  • Martin Doerr <mdoerr@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4662/head:pull/4662
$ git checkout pull/4662

Update a local copy of the PR:
$ git checkout pull/4662
$ git pull https://git.openjdk.java.net/jdk pull/4662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4662

View PR using the GUI difftool:
$ git pr show -t 4662

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4662.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 2, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@kelthuzadx The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 2, 2021

/label remove Shenandoah

/label remove hotspot

/label add hotspot-compiler

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@kelthuzadx The label Shenandoah is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

Loading

@openjdk openjdk bot removed the hotspot label Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@kelthuzadx
The hotspot label was successfully removed.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@kelthuzadx
The hotspot-compiler label was successfully added.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 2, 2021

/label remove shenandoah

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 2, 2021

Webrevs

Loading

@openjdk openjdk bot removed the shenandoah label Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@kelthuzadx
The shenandoah label was successfully removed.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 2, 2021

/contributor add mdoerr

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@kelthuzadx
Contributor Martin Doerr <mdoerr@openjdk.org> successfully added.

Loading

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269672: C1: Remove unaligned move on all architectures

Co-authored-by: Martin Doerr <mdoerr@openjdk.org>
Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 371d996: 8269700: source level for IntelliJ JDK project is set incorrectly
  • 8a7b380: 8269124: Update java.time to use switch expressions (part II)
  • 675a952: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work
  • 4da52ea: 8269004: Implement ResizableResourceHashtable
  • 390d102: 8269652: Factor out the common code for creating system j.l.Thread objects
  • 17f53f2: Merge
  • 1c18f91: 8269768: JFR Terminology Refresh
  • 6f0e8e7: 8269775: compiler/codegen/ClearArrayTest.java failed with "assert(false) failed: bad AD file"
  • c4ea13e: 8269543: The warning for System::setSecurityManager should only appear once for each caller
  • 2db9005: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/06d26208c5604c0c640eff4da94ef814c2ebebf0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 5, 2021
@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 6, 2021

Thank you, Tobias! I'd like to treat this non-functional change as "trivial" change.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

Going to push as commit df0e11b.
Since your change was applied there have been 48 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@kelthuzadx Pushed as commit df0e11b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kelthuzadx kelthuzadx deleted the remove_unaligned branch Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants