New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269672: C1: Remove unaligned move on all architectures #4662
Conversation
|
@kelthuzadx The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label remove Shenandoah /label remove hotspot /label add hotspot-compiler |
@kelthuzadx The label
|
@kelthuzadx |
@kelthuzadx |
/label remove shenandoah |
@kelthuzadx |
/contributor add mdoerr |
@kelthuzadx |
@kelthuzadx This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 38 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thank you, Tobias! I'd like to treat this non-functional change as "trivial" change. /integrate |
Going to push as commit df0e11b.
Your commit was automatically rebased without conflicts. |
@kelthuzadx Pushed as commit df0e11b. |
This is a follow up PR for #3917, it's rather a cleanup, no functional change.
As @TheRealMDoerr said
The "unaligned" parameter is unused on all platforms, now. Note that PPC64 and s390 support unaligned accesses, too. I believe it was used by SPARC which has been removed.
Thanks!
Progress
Issue
Reviewers
Contributors
<mdoerr@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4662/head:pull/4662
$ git checkout pull/4662
Update a local copy of the PR:
$ git checkout pull/4662
$ git pull https://git.openjdk.java.net/jdk pull/4662/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4662
View PR using the GUI difftool:
$ git pr show -t 4662
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4662.diff