Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269803: G1: remove unnecessary NoRefDiscovery #4664

Closed
wants to merge 2 commits into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 2, 2021

Simple change of removing the unnecessary disable of ref-discovery for CM during young-gc pause.

Test: hotspot_gc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4664/head:pull/4664
$ git checkout pull/4664

Update a local copy of the PR:
$ git checkout pull/4664
$ git pull https://git.openjdk.java.net/jdk pull/4664/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4664

View PR using the GUI difftool:
$ git pr show -t 4664

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4664.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 2, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jul 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 2, 2021

Webrevs

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

I think the comment beginning g1CollectedHeap.hpp:929 should be adapted too.

Looks good otherwise.

Loading

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 6, 2021

I think the comment beginning g1CollectedHeap.hpp:929 should be adapted too.

Looks good otherwise.

Other than the mentioned need for a comment update, I also thing this looks good.

Loading

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jul 7, 2021

Updated the comments.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269803: G1: remove unnecessary NoRefDiscovery

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

  • f741e4c: 8264735: Make dynamic dump repeatable
  • d1cecaa: 8269481: SctpMultiChannel never releases own file descriptor
  • 2209e3e: 8270027: ProblemList jdk/jfr/event/oldobject/TestObjectSize.java on macOS-x64
  • 2dc5486: 8267303: Replace MinObjectAlignmentSize usages for non-Java heap objects
  • 3586a23: 8268635: Corrupt oop in ClassLoaderData
  • bffb1a7: 8269923: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java failed with "FATAL ERROR in native method: Primitive type array expected but not received for JNI array operation"
  • 77a5b7b: 8269761: idea.sh missing .exe suffix when invoking javac on WSL
  • 248aa50: 8269294: Verify_before/after_young_collection should execute all verification
  • 18b80c7: 8269908: Move MemoryService::track_memory_usage call into G1MonitoringScope
  • a685011: 8269022: Put evacuation failure string directly into gc=info log message
  • ... and 50 more: https://git.openjdk.java.net/jdk/compare/f8bcbf0172af25ac17b110d22232bd618cfd621a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 7, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

Loading

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jul 8, 2021

Thanks for the review.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

Going to push as commit a96012f.
Since your change was applied there have been 72 commits pushed to the master branch:

  • 4e18ec2: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • e54585b: 8268363: AArch64: Implement string_indexof_char intrinsic in SVE
  • 270fbcb: Merge
  • c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
  • 6000950: 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different
  • 1f2bf1d: 8269879: [PPC64] C2: Math.rint intrinsic uses wrong rounding mode
  • 7fcd5ca: 8266036: class file for sun.misc.Contended not found
  • a49b1dc: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
  • 820f290: 8268859: jshell throws exception while parsing illegal "case true"
  • 815e4af: 8269802: javac fails to compile nested pattern matching switches
  • ... and 62 more: https://git.openjdk.java.net/jdk/compare/f8bcbf0172af25ac17b110d22232bd618cfd621a...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@albertnetymk Pushed as commit a96012f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@albertnetymk albertnetymk deleted the cm_discovery branch Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants