Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE #4665

Closed
wants to merge 4 commits into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jul 2, 2021

com.sun.net.httpserver.HttpServer::createContext specifies IllegalArgumentException to be thrown if a context already exists for the path provided. The implementation classsun.net.httpserver.ServerImpl does not comply with this, which is fixed by this change.

Testing: Tier 1-3 all clear.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4665/head:pull/4665
$ git checkout pull/4665

Update a local copy of the PR:
$ git checkout pull/4665
$ git pull https://git.openjdk.java.net/jdk pull/4665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4665

View PR using the GUI difftool:
$ git pr show -t 4665

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4665.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 2, 2021

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Jul 2, 2021
@openjdk openjdk bot added the rfr label Jul 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 2, 2021

Webrevs

dfuch
dfuch approved these changes Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 6, 2021
@FrauBoes
Copy link
Member Author

@FrauBoes FrauBoes commented Jul 6, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

Going to push as commit f485171.
Since your change was applied there have been 49 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@FrauBoes Pushed as commit f485171.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
3 participants