8269827: JMH tests for AES/GCM byte[] and bytebuffers #4672

ascarpino · 2021-07-02T19:13:48Z

Hi,

I need a review of these new jmh tests that run AES/GCM encryption and decryption using byte[], heap bytebuffers, and direct bytebuffers as input and output buffers for single and multi-part testing.

thanks

Tony

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8269827: JMH tests for AES/GCM byte[] and bytebuffers

Reviewers

Eric Caspole (@ericcaspole - Committer) ⚠️ Review applies to 0c7113e
Weijun Wang (@wangweij - Reviewer) ⚠️ Review applies to 2a7d1df

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4672/head:pull/4672
$ git checkout pull/4672

Update a local copy of the PR:
$ git checkout pull/4672
$ git pull https://git.openjdk.java.net/jdk pull/4672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4672

View PR using the GUI difftool:
$ git pr show -t 4672

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4672.diff

bridgekeeper · 2021-07-02T19:14:44Z

👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-07-02T19:18:14Z

@ascarpino The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-07-02T19:23:10Z

Webrevs

wangweij · 2021-07-06T15:38:20Z

test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java

    @Param({"128"})
    private int keyLength;

-    @Param({""+16*1024})
+    @Param({"" + 1024, "" +  1500, "" + 4096, "" + 16384})


Now that you don't calculate anymore, how about just string literals like "1024" etc?

Funny.. I didn't even notice that

wangweij · 2021-07-06T15:40:09Z

test/micro/org/openjdk/bench/javax/crypto/full/AESGCMByteBuffer.java

+ * This test rotates the IV and creates a new GCMParameterSpec for each encrypt
+ * benchmark operation
+ */
+


Do you want to create a "small" version?

I debated it.. I'm still not sure, but I guess I could.

wangweij · 2021-07-06T15:41:27Z

test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java

    private Cipher encryptCipher;
    private Cipher decryptCipher;
    SecretKeySpec ks;
    GCMParameterSpec gcm_spec;
-    byte[] aad;


Not an expert on this, but why no more AAD?

For a performance test there isn't any value in adding an AAD. It's data sitting in a buffer that an be easily replicated with a multipart operation

ericcaspole · 2021-07-06T19:34:05Z

From the JMH point of view, looks good to me.

ericcaspole

From the JMH point of view, looks good to me.

wangweij · 2021-07-08T14:39:20Z

test/micro/org/openjdk/bench/javax/crypto/full/AESGCMByteBuffer.java

+    @Param({"128"})
+    private int keyLength;
+
+    @Param({"" + 1024, "" + 1500, "" + 4096, "" + 16384})


You can update the line above as well.

Grr.. I'm not sure how I missed that one

openjdk · 2021-07-08T14:45:38Z

@ascarpino This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269827: JMH tests for AES/GCM byte[] and bytebuffers

Reviewed-by: ecaspole, weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 447 new commits pushed to the master branch:

6f171b9: 8268965: TCP Connection Reset when connecting simple socket to SSL server
4f322a9: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
bca570c: 8269962: SA has unused Hashtable, Dictionary classes
4a45d95: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java
30bba54: 8270064: Problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java due to JDK-8270060
2c883ee: 8267982: Set the node after peephole optimization to be removed
4fbcce1: 8269886: Inaccurate error message for compressed hprof test
a96012f: 8269803: G1: remove unnecessary NoRefDiscovery
4e18ec2: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
e54585b: 8268363: AArch64: Implement string_indexof_char intrinsic in SVE
... and 437 more: https://git.openjdk.java.net/jdk/compare/fafc4d976434c196c16b652c859073c5888b992e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

ascarpino · 2021-07-08T17:18:22Z

/integrate

openjdk · 2021-07-08T17:20:00Z

Going to push as commit 5832882.
Since your change was applied there have been 447 commits pushed to the master branch:

6f171b9: 8268965: TCP Connection Reset when connecting simple socket to SSL server
4f322a9: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
bca570c: 8269962: SA has unused Hashtable, Dictionary classes
4a45d95: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java
30bba54: 8270064: Problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java due to JDK-8270060
2c883ee: 8267982: Set the node after peephole optimization to be removed
4fbcce1: 8269886: Inaccurate error message for compressed hprof test
a96012f: 8269803: G1: remove unnecessary NoRefDiscovery
4e18ec2: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
e54585b: 8268363: AArch64: Implement string_indexof_char intrinsic in SVE
... and 437 more: https://git.openjdk.java.net/jdk/compare/fafc4d976434c196c16b652c859073c5888b992e...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-08T17:20:18Z

@ascarpino Pushed as commit 5832882.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

ascarpino added 2 commits June 25, 2021 09:46

initial checkin

6b34ac5

cleanup

ad46303

openjdk bot added the rfr Pull request is ready for review label Jul 2, 2021

openjdk bot added the security security-dev@openjdk.org label Jul 2, 2021

merge AESGCMByteArray with existing AESGCMBench

0c7113e

wangweij reviewed Jul 6, 2021

View reviewed changes

ericcaspole approved these changes Jul 6, 2021

View reviewed changes

Add small.AESGCMByteBuffer and fix dataSize

2a7d1df

wangweij approved these changes Jul 8, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2021

full.AESGCMByteBuffer dataSize

4d43cff

openjdk bot closed this Jul 8, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2021

ascarpino deleted the micro branch July 8, 2021 21:51

8269827: JMH tests for AES/GCM byte[] and bytebuffers #4672

8269827: JMH tests for AES/GCM byte[] and bytebuffers #4672

ascarpino commented Jul 2, 2021 •

edited by openjdk bot

bridgekeeper bot commented Jul 2, 2021

openjdk bot commented Jul 2, 2021

mlbridge bot commented Jul 2, 2021 •

edited

wangweij Jul 6, 2021

ascarpino Jul 6, 2021

wangweij Jul 6, 2021

ascarpino Jul 6, 2021

wangweij Jul 6, 2021

ascarpino Jul 6, 2021

ericcaspole commented Jul 6, 2021

ericcaspole left a comment

wangweij Jul 8, 2021

ascarpino Jul 8, 2021

openjdk bot commented Jul 8, 2021 •

edited

ascarpino commented Jul 8, 2021

openjdk bot commented Jul 8, 2021

openjdk bot commented Jul 8, 2021

8269827: JMH tests for AES/GCM byte[] and bytebuffers #4672

8269827: JMH tests for AES/GCM byte[] and bytebuffers #4672

Conversation

ascarpino commented Jul 2, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 2, 2021

openjdk bot commented Jul 2, 2021

mlbridge bot commented Jul 2, 2021 • edited

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericcaspole commented Jul 6, 2021

ericcaspole left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Jul 8, 2021 • edited

ascarpino commented Jul 8, 2021

openjdk bot commented Jul 8, 2021

openjdk bot commented Jul 8, 2021

ascarpino commented Jul 2, 2021 •

edited by openjdk bot

mlbridge bot commented Jul 2, 2021 •

edited

openjdk bot commented Jul 8, 2021 •

edited