8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error

[alexmenkov]

SocketIOPipe/IOPipe classes can select listening port by 2 ways:

1. caller specifies "-transport.address=dynamic" argument creating ArgumentHandler,
   and calls Binder.prepareForPipeConnection (actually see nsk.share.jpda.DebugeeBinder.prepareForPipeConnection()) before start listening.
   In the case prepareForPipeConnection creates socket and this socket later is used by IOPipe.
2. just start IOPipe listening.
   Then port is selected by calling nsk.share.jpda.DebugeeArgumentHandler.getTransportPort() which use findFreePort() method:

    ServerSocket ss;
    try {
        ss = new ServerSocket(0);
        return String.valueOf(ss.getLocalPort());
    }finally {
        ss.close();
    }

This method is known to be error prone (sometimes causes "address in use" error).

The fix adds "-transport.address=dynamic" argument so IOPipe use 1st method.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Kevin Walls (@kevinjwalls - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4676/head:pull/4676
$ git checkout pull/4676

Update a local copy of the PR:
$ git checkout pull/4676
$ git pull https://git.openjdk.java.net/jdk pull/4676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4676

View PR using the GUI difftool:
$ git pr show -t 4676

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4676.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (86f97a74)

[sspitsyn]

LGTM.
Thanks,
Serguei

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 283 new commits pushed to the master branch:

• c2ed336: 8270912: Clean up G1CollectedHeap::process_discovered_references()
• 8e27d4e: 8271043: Rename G1CollectedHeap::g1mm()
• d1257d5: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
• 50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API
• 9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
• 6096dd9: 8268893: jcmd to trim the glibc heap
• c36755d: Merge
• 89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
• e1051ae: 8264066: Enhance compiler validation
• add995b: 8265201: JarFile.getInputStream not validating invalid signed jars
• ... and 273 more: https://git.openjdk.java.net/jdk/compare/83bce94cc8a7fb45b0604598411fbecc62000dfd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 8785737.
Since your change was applied there have been 334 commits pushed to the master branch:

• 3aadae2: 8271140: Fix native frame handling in vframeStream::asJavaVFrame()
• b8f79a7: 8268873: Unnecessary Vector usage in java.base
• 0b12e7c: 8075806: divideExact is missing in java.lang.Math
• efa63dc: 8171382: java.time.Duration missing isPositive method
• ee55361: 8265474: Dubious 'null' assignment in CompactByteArray.expand
• 515113d: 8269924: Shenandoah: Introduce weak/strong marking asserts
• f2c359a: 8271215: Fix data races in G1PeriodicGCTask
• 36aefa3: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
• e4295cc: 8270519: Move several vector helper methods to shared header file
• e627cae: 8270317: Large Allocation in CipherSuite
• ... and 324 more: https://git.openjdk.java.net/jdk/compare/83bce94cc8a7fb45b0604598411fbecc62000dfd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 8785737.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.