Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269882: stack-use-after-scope in NewObjectA #4683

Closed
wants to merge 1 commit into from

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jul 5, 2021

Please review this trivial fix to add '&' so that a macro parameter is passed as a reference.

See bug for details.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4683/head:pull/4683
$ git checkout pull/4683

Update a local copy of the PR:
$ git checkout pull/4683
$ git pull https://git.openjdk.java.net/jdk pull/4683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4683

View PR using the GUI difftool:
$ git pr show -t 4683

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4683.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 5, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Jul 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 5, 2021

Webrevs

Loading

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Jul 5, 2021

/label remove hotspot
/label add hotspot-runtime

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

@dholmes-ora
The hotspot label was successfully removed.

Loading

@openjdk openjdk bot added hotspot-runtime and removed hotspot labels Jul 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

@dholmes-ora
The hotspot-runtime label was successfully added.

Loading

Copy link

@kimbarrett kimbarrett left a comment

Looks good, and trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269882: stack-use-after-scope in NewObjectA

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • df0e11b: 8269672: C1: Remove unaligned move on all architectures
  • 2926769: 8267956: C1 code cleanup
  • acc3d99: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • a18a112: Merge
  • 5b8e1a2: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException
  • e14801c: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 97e0e9e: 8268775: Password is being converted to String in AccessibleJPasswordField

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Jul 6, 2021

Thanks for the review Kim.

/integrate

Loading

@openjdk openjdk bot added the ready label Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

Going to push as commit 20eba35.
Since your change was applied there have been 7 commits pushed to the master branch:

  • df0e11b: 8269672: C1: Remove unaligned move on all architectures
  • 2926769: 8267956: C1 code cleanup
  • acc3d99: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • a18a112: Merge
  • 5b8e1a2: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException
  • e14801c: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 97e0e9e: 8268775: Password is being converted to String in AccessibleJPasswordField

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 6, 2021
@openjdk openjdk bot added integrated and removed ready labels Jul 6, 2021
@dholmes-ora dholmes-ora deleted the 8269882 branch Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@dholmes-ora Pushed as commit 20eba35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants