8269882: stack-use-after-scope in NewObjectA

[dholmes-ora]

Please review this trivial fix to add '&' so that a macro parameter is passed as a reference.

See bug for details.

Thanks,
David

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269882: stack-use-after-scope in NewObjectA

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4683/head:pull/4683
$ git checkout pull/4683

Update a local copy of the PR:
$ git checkout pull/4683
$ git pull https://git.openjdk.java.net/jdk pull/4683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4683

View PR using the GUI difftool:
$ git pr show -t 4683

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4683.diff

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (614211a7)

[dholmes-ora]

/label remove hotspot
/label add hotspot-runtime

[openjdk]

@dholmes-ora
The hotspot label was successfully removed.

[openjdk]

@dholmes-ora
The hotspot-runtime label was successfully added.

[kimbarrett]

Looks good, and trivial.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269882: stack-use-after-scope in NewObjectA

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• df0e11b: 8269672: C1: Remove unaligned move on all architectures
• 2926769: 8267956: C1 code cleanup
• acc3d99: 8268860: Windows-Aarch64 build is failing in GitHub actions
• a18a112: Merge
• 5b8e1a2: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException
• e14801c: 8269668: [aarch64] java.library.path not including /usr/lib64
• 97e0e9e: 8268775: Password is being converted to String in AccessibleJPasswordField

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks for the review Kim.

/integrate

[openjdk]

Going to push as commit 20eba35.
Since your change was applied there have been 7 commits pushed to the master branch:

• df0e11b: 8269672: C1: Remove unaligned move on all architectures
• 2926769: 8267956: C1 code cleanup
• acc3d99: 8268860: Windows-Aarch64 build is failing in GitHub actions
• a18a112: Merge
• 5b8e1a2: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException
• e14801c: 8269668: [aarch64] java.library.path not including /usr/lib64
• 97e0e9e: 8268775: Password is being converted to String in AccessibleJPasswordField

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit 20eba35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.